Changeset 13849 in josm

Timestamp:

2018-05-26T19:36:19+02:00 (6 years ago)

Author:

Don-vip

Message:

SonarQube - fix minor code issues

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/downloadtasks/ChangesetContentDownloadTask.java (modified) (1 diff)
• actions/downloadtasks/PostDownloadHandler.java (modified) (1 diff)
• actions/mapmode/SelectAction.java (modified) (4 diffs)
• data/Preferences.java (modified) (2 diffs)
• data/coor/conversion/package-info.java (added)
• data/projection/ProjectionCLI.java (modified) (4 diffs)
• data/validation/tests/WronglyOrderedWays.java (modified) (1 diff)
• gui/ExceptionDialogUtil.java (modified) (1 diff)
• gui/autofilter/AutoFilterRule.java (modified) (3 diffs)
• gui/dialogs/LayerListDialog.java (modified) (1 diff)
• gui/dialogs/changeset/query/DateValidator.java (modified) (1 diff)
• gui/dialogs/changeset/query/TimeValidator.java (modified) (1 diff)
• gui/dialogs/layer/LayerVisibilityAction.java (modified) (1 diff)
• gui/dialogs/properties/AbstractCopyAction.java (modified) (3 diffs)
• gui/dialogs/properties/CopyAllKeyValueAction.java (modified) (2 diffs)
• gui/dialogs/properties/CopyKeyValueAction.java (modified) (2 diffs)
• gui/dialogs/properties/CopyValueAction.java (modified) (2 diffs)
• gui/dialogs/properties/HelpAction.java (modified) (3 diffs)
• gui/dialogs/properties/TaginfoAction.java (modified) (3 diffs)
• gui/dialogs/relation/actions/AddFromSelectionAction.java (modified) (1 diff)
• gui/history/HistoryLoadTask.java (modified) (1 diff)
• gui/history/TagInfoViewer.java (modified) (2 diffs)
• gui/io/CredentialDialog.java (modified) (1 diff)
• gui/layer/GpxLayer.java (modified) (1 diff)
• gui/mappaint/RenderingCLI.java (modified) (6 diffs)
• gui/oauth/RetrieveAccessTokenTask.java (modified) (1 diff)
• gui/oauth/RetrieveRequestTokenTask.java (modified) (1 diff)
• gui/preferences/display/ColorPreference.java (modified) (2 diffs)
• gui/preferences/server/ApiUrlTestTask.java (modified) (1 diff)
• gui/tagging/presets/TaggingPresetNameTemplateList.java (modified) (1 diff)
• gui/widgets/OsmIdTextField.java (modified) (1 diff)
• io/OsmConnection.java (modified) (1 diff)
• plugins/PluginClassLoader.java (modified) (1 diff)
• tools/HiDPISupport.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/downloadtasks/ChangesetContentDownloadTask.java

@@ -78 +78 @@
                 setCanceled(true);
                 Logging.trace(e);
-                return;
             } catch (OsmTransferException e) {
-                if (isCanceled())
-                    return;
-                rememberLastException(e);
+                if (!isCanceled()) {
+                    rememberLastException(e);
+                }
             }
         }

trunk/src/org/openstreetmap/josm/actions/downloadtasks/PostDownloadHandler.java

@@ -120 +120 @@
                         JOptionPane.ERROR_MESSAGE));
             }
-            return;
         }
     }

trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -275 +275 @@
         }
 
-        mv.setNewCursor(getCursor(c), this);
+        mv.setNewCursor(getCursor(c.orElse(null)), this);
 
         // return early if there can't be any highlights
@@ -296 +296 @@
      * features. The only exception is the "move" cursor when actually dragging
      * primitives.
-     * @param nearbyStuff  primitives near the cursor
+     * @param nearbyStuff primitives near the cursor
      * @return the cursor that should be displayed
      */
-    private Cursor getCursor(Optional<OsmPrimitive> nearbyStuff) {
+    private Cursor getCursor(OsmPrimitive nearbyStuff) {
         String c = "rect";
         switch(mode) {
@@ -307 +307 @@
                 break;
             }
-            final OsmPrimitive osm = nearbyStuff.orElse(null);
+            final OsmPrimitive osm = nearbyStuff;
 
             if (dragInProgress()) {
@@ -516 +516 @@
                 needsRepaint = true;
             }
-            mv.setNewCursor(getCursor(Optional.ofNullable(p)), this);
+            mv.setNewCursor(getCursor(p), this);
             // also update the stored mouse event, so we can display the correct cursor
             // when dragging a node onto another one and then press CTRL to merge

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -406 +406 @@
                 continue;
             Utils.instanceOfAndCast(e.getValue(), ListSetting.class)
-                    .map(d -> d.getValue())
+                    .map(ListSetting::getValue)
                     .map(lst -> ColorInfo.fromPref(lst, false))
                     .ifPresent(info -> all.put(e.getKey(), info));
@@ -414 +414 @@
                 continue;
             Utils.instanceOfAndCast(e.getValue(), ListSetting.class)
-                    .map(d -> d.getValue())
+                    .map(ListSetting::getValue)
                     .map(lst -> ColorInfo.fromPref(lst, true))
                     .ifPresent(infoDef -> {

trunk/src/org/openstreetmap/josm/data/projection/ProjectionCLI.java

@@ -33 +33 @@
     public static final ProjectionCLI INSTANCE = new ProjectionCLI();
 
-    private boolean argInverse = false;         // NOPMD
-    private boolean argSwitchInput = false;     // NOPMD
-    private boolean argSwitchOutput = false;    // NOPMD
+    private boolean argInverse;
+    private boolean argSwitchInput;
+    private boolean argSwitchOutput;
 
     @Override
@@ -77 +77 @@
             if (arg.isEmpty()) throw new IllegalArgumentException("non-empty argument expected");
             if (arg.startsWith("+")) {
-                if (arg.equals("+to")) {
+                if ("+to".equals(arg)) {
                     toTokenSeen = true;
                 } else {
@@ -142 +142 @@
         }
 
-        if (files.isEmpty() || files.get(0).equals("-")) {
+        if (files.isEmpty() || "-".equals(files.get(0))) {
             processInput(fromProj, toProj, new BufferedReader(new InputStreamReader(System.in, Charset.defaultCharset())));
         } else {
@@ -174 +174 @@
     }
 
-    private CustomProjection createProjection(String params) throws ProjectionConfigurationException {
+    private static CustomProjection createProjection(String params) throws ProjectionConfigurationException {
         CustomProjection proj = new CustomProjection();
         proj.update(params);

trunk/src/org/openstreetmap/josm/data/validation/tests/WronglyOrderedWays.java

@@ -37 +37 @@
 
         String natural = w.get("natural");
-        if (natural == null)
+        if (natural == null) {
             return;
-        else if ("coastline".equals(natural) && Geometry.isClockwise(w)) {
+        } else if ("coastline".equals(natural) && Geometry.isClockwise(w)) {
             reportError(w, tr("Reversed coastline: land not on left side"), WRONGLY_ORDERED_COAST);
         } else if ("land".equals(natural) && Geometry.isClockwise(w)) {
             reportError(w, tr("Reversed land: land not on left side"), WRONGLY_ORDERED_LAND);
-        } else
-            return;
-
+        }
     }
 

trunk/src/org/openstreetmap/josm/gui/ExceptionDialogUtil.java

@@ -194 +194 @@
         if (ex != null) {
             // Users should be able to submit a bug report for an invocation target exception
-            //
             BugReportExceptionHandler.handleException(ex);
-            return;
         }
     }

trunk/src/org/openstreetmap/josm/gui/autofilter/AutoFilterRule.java

@@ -5 +5 @@
 import java.util.Objects;
 import java.util.function.Function;
+import java.util.function.UnaryOperator;
 
 /**
@@ -19 +20 @@
     private final int minZoomLevel;
 
-    private Function<String, String> valueFormatter = s -> s;
+    private UnaryOperator<String> valueFormatter = s -> s;
 
     private Comparator<String> valueComparator = Comparator.comparingInt(s -> Integer.parseInt(valueFormatter.apply(s)));
@@ -63 +64 @@
      * @throws NullPointerException if {@code valueFormatter} is null
      */
-    public AutoFilterRule setValueFormatter(Function<String, String> valueFormatter) {
+    public AutoFilterRule setValueFormatter(UnaryOperator<String> valueFormatter) {
         this.valueFormatter = Objects.requireNonNull(valueFormatter);
         return this;

trunk/src/org/openstreetmap/josm/gui/dialogs/LayerListDialog.java

@@ -604 +604 @@
                 AbstractProperty<Color> prop = layer.getColorProperty();
                 Color c = prop == null ? null : prop.get();
-                if (c == null || !model.getLayers().stream()
+                if (c == null || model.getLayers().stream()
                         .map(Layer::getColorProperty)
                         .filter(Objects::nonNull)
                         .map(AbstractProperty::get)
-                        .anyMatch(oc -> oc != null && !oc.equals(c))) {
+                        .noneMatch(oc -> oc != null && !oc.equals(c))) {
                     /* not more than one color, don't use coloring */
                     label.setForeground(UIManager.getColor(isSelected ? "Table.selectionForeground" : "Table.foreground"));

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/query/DateValidator.java

@@ -78 +78 @@
             String msg = "<html>The current value isn't a valid date.<br>" + getStandardTooltipText()+ "</html>";
             feedbackInvalid(msg);
-            return;
         } else {
             String msg = "<html>" + getStandardTooltipText() + "</html>";

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/query/TimeValidator.java

@@ -80 +80 @@
             String msg = "<html>The current value isn't a valid time.<br>" + getStandardTooltipText() + "</html>";
             feedbackInvalid(msg);
-            return;
         } else {
             String msg = "<html>" + getStandardTooltipText() + "</html>";

trunk/src/org/openstreetmap/josm/gui/dialogs/layer/LayerVisibilityAction.java

@@ -300 +300 @@
             Collection<? extends Layer> usedLayers = filterLayers(layers);
             setVisible(!usedLayers.isEmpty());
-            if (!usedLayers.stream().anyMatch(Layer::isVisible)) {
+            if (usedLayers.stream().noneMatch(Layer::isVisible)) {
                 slider.setEnabled(false);
             } else {

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/AbstractCopyAction.java

@@ -7 +7 @@
 import java.util.Set;
 import java.util.TreeSet;
-import java.util.function.Function;
+import java.util.function.IntFunction;
 import java.util.function.Supplier;
 
@@ -24 +24 @@
 
     private final JTable tagTable;
-    private final Function<Integer, String> keySupplier;
+    private final IntFunction<String> keySupplier;
     private final Supplier<Collection<? extends Tagged>> objectSupplier;
 
@@ -33 +33 @@
      * @param objectSupplier a supplier which returns the selected tagged object(s)
      */
-    public AbstractCopyAction(JTable tagTable, Function<Integer, String> keySupplier, Supplier<Collection<? extends Tagged>> objectSupplier) {
+    public AbstractCopyAction(JTable tagTable, IntFunction<String> keySupplier, Supplier<Collection<? extends Tagged>> objectSupplier) {
         this.tagTable = Objects.requireNonNull(tagTable);
         this.keySupplier = Objects.requireNonNull(keySupplier);

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/CopyAllKeyValueAction.java

@@ -9 +9 @@
 import java.util.List;
 import java.util.Map.Entry;
-import java.util.function.Function;
+import java.util.function.IntFunction;
 import java.util.function.Supplier;
 
@@ -31 +31 @@
      * @param objectSp a supplier which returns the selected tagged object(s)
      */
-    public CopyAllKeyValueAction(JTable tagTable, Function<Integer, String> keyFn, Supplier<Collection<? extends Tagged>> objectSp) {
+    public CopyAllKeyValueAction(JTable tagTable, IntFunction<String> keyFn, Supplier<Collection<? extends Tagged>> objectSp) {
         super(tagTable, keyFn, objectSp);
         putValue(NAME, tr("Copy all Keys/Values"));

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/CopyKeyValueAction.java

@@ -6 +6 @@
 import java.util.Collection;
 import java.util.Collections;
-import java.util.function.Function;
+import java.util.function.IntFunction;
 import java.util.function.Supplier;
 
@@ -26 +26 @@
      * @param objectSp a supplier which returns the selected tagged object(s)
      */
-    public CopyKeyValueAction(JTable tagTable, Function<Integer, String> keyFn, Supplier<Collection<? extends Tagged>> objectSp) {
+    public CopyKeyValueAction(JTable tagTable, IntFunction<String> keyFn, Supplier<Collection<? extends Tagged>> objectSp) {
         super(tagTable, keyFn, objectSp);
         putValue(NAME, tr("Copy selected Key(s)/Value(s)"));

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/CopyValueAction.java

@@ -6 +6 @@
 import java.util.Collection;
 import java.util.Collections;
-import java.util.function.Function;
+import java.util.function.IntFunction;
 import java.util.function.Supplier;
 
@@ -25 +25 @@
      * @param objectSp a supplier which returns the selected tagged object(s)
      */
-    public CopyValueAction(JTable tagTable, Function<Integer, String> keyFn, Supplier<Collection<? extends Tagged>> objectSp) {
+    public CopyValueAction(JTable tagTable, IntFunction<String> keyFn, Supplier<Collection<? extends Tagged>> objectSp) {
         super(tagTable, keyFn, objectSp);
         putValue(NAME, tr("Copy Value"));

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/HelpAction.java

@@ -14 +14 @@
 import java.util.Map;
 import java.util.Objects;
-import java.util.function.Function;
+import java.util.function.IntFunction;
 
 import javax.swing.AbstractAction;
@@ -36 +36 @@
 public class HelpAction extends AbstractAction {
     private final JTable tagTable;
-    private final Function<Integer, String> tagKeySupplier;
-    private final Function<Integer, Map<String, Integer>> tagValuesSupplier;
+    private final IntFunction<String> tagKeySupplier;
+    private final IntFunction<Map<String, Integer>> tagValuesSupplier;
 
     private final JTable membershipTable;
-    private final Function<Integer, Relation> memberValueSupplier;
+    private final IntFunction<Relation> memberValueSupplier;
 
     /**
@@ -50 +50 @@
      * @param memberValueSupplier Finds the parent relation from given row of membership table. Can be null
      */
-    public HelpAction(JTable tagTable, Function<Integer, String> tagKeySupplier, Function<Integer, Map<String, Integer>> tagValuesSupplier,
-            JTable membershipTable, Function<Integer, Relation> memberValueSupplier) {
+    public HelpAction(JTable tagTable, IntFunction<String> tagKeySupplier, IntFunction<Map<String, Integer>> tagValuesSupplier,
+            JTable membershipTable, IntFunction<Relation> memberValueSupplier) {
         this.tagTable = Objects.requireNonNull(tagTable);
         this.tagKeySupplier = Objects.requireNonNull(tagKeySupplier);

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TaginfoAction.java

@@ -7 +7 @@
 import java.util.Map;
 import java.util.Objects;
-import java.util.function.Function;
+import java.util.function.IntFunction;
 
 import javax.swing.JTable;
@@ -26 +26 @@
 
     private final JTable tagTable;
-    private final Function<Integer, String> tagKeySupplier;
-    private final Function<Integer, Map<String, Integer>> tagValuesSupplier;
+    private final IntFunction<String> tagKeySupplier;
+    private final IntFunction<Map<String, Integer>> tagValuesSupplier;
 
     private final JTable membershipTable;
-    private final Function<Integer, Relation> memberValueSupplier;
+    private final IntFunction<Relation> memberValueSupplier;
 
     /**
@@ -40 +40 @@
      * @param memberValueSupplier Finds the parent relation from given row of membership table. Can be null
      */
-    public TaginfoAction(JTable tagTable, Function<Integer, String> tagKeySupplier, Function<Integer, Map<String, Integer>> tagValuesSupplier,
-            JTable membershipTable, Function<Integer, Relation> memberValueSupplier) {
+    public TaginfoAction(JTable tagTable, IntFunction<String> tagKeySupplier, IntFunction<Map<String, Integer>> tagValuesSupplier,
+            JTable membershipTable, IntFunction<Relation> memberValueSupplier) {
         super(tr("Go to Taginfo"), "dialogs/taginfo", tr("Launch browser with Taginfo statistics for selected object"), null, false);
         this.tagTable = Objects.requireNonNull(tagTable);

trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/AddFromSelectionAction.java

@@ -52 +52 @@
                     ret.add(primitive);
                 }
-                continue;
             } else {
                 ret.add(primitive);

trunk/src/org/openstreetmap/josm/gui/history/HistoryLoadTask.java

@@ -174 +174 @@
         } catch (OsmTransferException e) {
             lastException = e;
-            return;
         }
     }

trunk/src/org/openstreetmap/josm/gui/history/TagInfoViewer.java

@@ -8 +8 @@
 import java.util.HashMap;
 import java.util.Map;
-import java.util.function.Function;
+import java.util.function.IntFunction;
 import java.util.function.Supplier;
 
@@ -80 +80 @@
         JPopupMenu tagMenu = new JPopupMenu();
 
-        Function<Integer, String> tagKeyFn = x -> (String) table.getValueAt(x, 0);
-        Function<Integer, Map<String, Integer>> tagValuesFn = x -> {
+        IntFunction<String> tagKeyFn = x -> (String) table.getValueAt(x, 0);
+        IntFunction<Map<String, Integer>> tagValuesFn = x -> {
             Map<String, Integer> map = new HashMap<>();
             String key = tagTableModel.getValue((String) table.getValueAt(x, 0));

trunk/src/org/openstreetmap/josm/gui/io/CredentialDialog.java

@@ -402 +402 @@
                 if (currentTF.getText().trim().isEmpty()) {
                     currentTF.selectAll();
-                    return;
                 } else if (nextTF.getText().trim().isEmpty()) {
                     nextTF.requestFocusInWindow();
                     nextTF.selectAll();
-                    return;
                 } else {
                     owner.new OKAction().actionPerformed(null);

trunk/src/org/openstreetmap/josm/gui/layer/GpxLayer.java

@@ -148 +148 @@
     public Object getInfoComponent() {
         StringBuilder info = new StringBuilder(128)
-                .append("<html><head><style>")
-                .append("td { padding: 4px 16px; }")
-                .append("</style></head><body>");
+                .append("<html><head><style>td { padding: 4px 16px; }</style></head><body>");
 
         if (data.attr.containsKey("name")) {

trunk/src/org/openstreetmap/josm/gui/mappaint/RenderingCLI.java

@@ -15 +15 @@
 import java.util.Locale;
 import java.util.Optional;
-import java.util.function.Supplier;
+import java.util.function.DoubleSupplier;
 import java.util.logging.Level;
 
@@ -238 +238 @@
                 break;
             case 'b':
-                if (!getopt.getOptarg().equals("auto")) {
+                if (!"auto".equals(getopt.getOptarg())) {
                     try {
                         argBounds = new Bounds(getopt.getOptarg(), ",", Bounds.ParseMethod.LEFT_BOTTOM_RIGHT_TOP, false);
@@ -459 +459 @@
                 EastNorth projAnchor = proj.latlon2eastNorth(argAnchor);
 
-                Double enPerMeter = null;
-                Supplier<Double> getEnPerMeter = () -> {
+                double enPerMeter = Double.NaN;
+                DoubleSupplier getEnPerMeter = () -> {
                     double shiftMeter = 10;
                     EastNorth projAnchorShifted = projAnchor.add(
@@ -470 +470 @@
                 if (scale == null) {
                     if (argScale != null) {
-                        enPerMeter = getEnPerMeter.get();
+                        enPerMeter = getEnPerMeter.getAsDouble();
                         scale = argScale * enPerMeter / PIXEL_PER_METER;
                     } else if (argWidthM != null && argWidthPx != null) {
-                        enPerMeter = getEnPerMeter.get();
+                        enPerMeter = getEnPerMeter.getAsDouble();
                         scale = argWidthM / argWidthPx * enPerMeter;
                     } else if (argHeightM != null && argHeightPx != null) {
-                        enPerMeter = getEnPerMeter.get();
+                        enPerMeter = getEnPerMeter.getAsDouble();
                         scale = argHeightM / argHeightPx * enPerMeter;
                     } else {
@@ -486 +486 @@
                 double widthEn;
                 if (argWidthM != null) {
-                    enPerMeter = Optional.ofNullable(enPerMeter).orElseGet(getEnPerMeter);
+                    if (enPerMeter == Double.NaN) {
+                        enPerMeter = getEnPerMeter.getAsDouble();
+                    }
                     widthEn = argWidthM * enPerMeter;
                 } else if (argWidthPx != null) {
@@ -497 +499 @@
                 double heightEn;
                 if (argHeightM != null) {
-                    enPerMeter = Optional.ofNullable(enPerMeter).orElseGet(getEnPerMeter);
+                    if (enPerMeter == Double.NaN) {
+                        enPerMeter = getEnPerMeter.getAsDouble();
+                    }
                     heightEn = argHeightM * enPerMeter;
                 } else if (argHeightPx != null) {

trunk/src/org/openstreetmap/josm/gui/oauth/RetrieveAccessTokenTask.java

@@ -88 +88 @@
         } catch (OsmTransferCanceledException e) {
             Logging.trace(e);
-            return;
         } catch (final OsmOAuthAuthorizationException e) {
             Logging.error(e);

trunk/src/org/openstreetmap/josm/gui/oauth/RetrieveRequestTokenTask.java

@@ -82 +82 @@
         } catch (OsmTransferCanceledException e) {
             Logging.trace(e);
-            return;
         } catch (final OsmOAuthAuthorizationException e) {
             Logging.error(e);

trunk/src/org/openstreetmap/josm/gui/preferences/display/ColorPreference.java

@@ -211 +211 @@
 
         @Override
-        public boolean isCellEditable(int rowIndex, int columnIndex) {
-            return false;
-        }
-
-        @Override
         public void setValueAt(Object aValue, int rowIndex, int columnIndex) {
             if (columnIndex == 1 && aValue instanceof Color) {
@@ -386 +381 @@
     }
 
-    private boolean isRemoveColor(ColorEntry ce) {
-        return ce.info.getCategory().equals(NamedColorProperty.COLOR_CATEGORY_LAYER);
+    private static boolean isRemoveColor(ColorEntry ce) {
+        return NamedColorProperty.COLOR_CATEGORY_LAYER.equals(ce.info.getCategory());
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/server/ApiUrlTestTask.java

@@ -202 +202 @@
             Logging.error(e);
             alertConnectionFailed();
-            return;
         }
     }

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetNameTemplateList.java

@@ -60 +60 @@
                         if (t.nameTemplateFilter.match(primitive))
                             return t;
-                        else {
-                            continue;
-                        }
                     } else if (t.matches(type, primitive.getKeys(), false)) {
                         return t;

trunk/src/org/openstreetmap/josm/gui/widgets/OsmIdTextField.java

@@ -104 +104 @@
                 // convert tokens to int skipping v-words (version v2 etc)
                 c = s.charAt(0);
-                if (c == 'v') {
-                    continue;
-                } else {
+                if (c != 'v') {
                     try {
                         ids.addAll(SimplePrimitiveId.multipleFromString(s));

trunk/src/org/openstreetmap/josm/io/OsmConnection.java

@@ -120 +120 @@
             if (response.isCanceled()) {
                 cancel = true;
-                return;
             } else {
                 String username = response.getUsername() == null ? "" : response.getUsername();

trunk/src/org/openstreetmap/josm/plugins/PluginClassLoader.java

@@ -47 +47 @@
         // Add dependency only if not already present (directly or transitively through another one)
         boolean result = !dependencies.contains(Objects.requireNonNull(dependency, "dependency"))
-                && !dependencies.stream().anyMatch(pcl -> pcl.dependencies.contains(dependency))
+                && dependencies.stream().noneMatch(pcl -> pcl.dependencies.contains(dependency))
                 && dependencies.add(dependency);
         if (result) {

trunk/src/org/openstreetmap/josm/tools/HiDPISupport.java

@@ -192 +192 @@
         }
         List<List<Image>> allVars = imgs.stream().map(HiDPISupport::getResolutionVariants).collect(Collectors.toList());
-        int maxVariants = allVars.stream().mapToInt(lst -> lst.size()).max().getAsInt();
+        int maxVariants = allVars.stream().mapToInt(List<Image>::size).max().getAsInt();
         if (maxVariants == 1)
             return processor.apply(imgs);