Changeset 13839 in josm for trunk/src/org/openstreetmap/josm/gui

Timestamp:

2018-05-26T09:08:02+02:00 (6 years ago)

Author:

wiktorn

Message:

Sonar fixes and javadoc

• AddImageryLayerAction - do not use {{ }} initialization as it may be source of leaks
• AbstractTileSourceLayer - do not expose partially initialized object, first set all the values, then set the class field
• WMTSCapabilities - add javadocs

File:

• trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java

@@ -1358 +1358 @@
                     if (info == null) {
                         List<Tile> allTiles = this.allExistingTiles();
-                        info = new TileSetInfo();
-                        info.hasLoadingTiles = allTiles.size() < this.size();
-                        info.hasAllLoadedTiles = true;
+                        TileSetInfo newInfo = new TileSetInfo();
+                        newInfo.hasLoadingTiles = allTiles.size() < this.size();
+                        newInfo.hasAllLoadedTiles = true;
                         for (Tile t : allTiles) {
                             if ("no-tile".equals(t.getValue("tile-info"))) {
-                                info.hasOverzoomedTiles = true;
+                                newInfo.hasOverzoomedTiles = true;
                             }
                             if (t.isLoaded()) {
                                 if (!t.hasError()) {
-                                    info.hasVisibleTiles = true;
+                                    newInfo.hasVisibleTiles = true;
                                 }
                             } else {
-                                info.hasAllLoadedTiles = false;
+                                newInfo.hasAllLoadedTiles = false;
                                 if (t.isLoading()) {
-                                    info.hasLoadingTiles = true;
+                                    newInfo.hasLoadingTiles = true;
                                 }
                             }
                         }
+                        info = newInfo;
                     }
                 }