Changeset 13828 in josm for trunk/src/org/openstreetmap/josm/gui

Timestamp:

2018-05-24T23:53:37+02:00 (6 years ago)

Author:

wiktorn

Message:

Sonar fixes, javadocs.

See: #16249

Location:

trunk/src/org/openstreetmap/josm/gui/preferences/imagery

Files:

• AddWMSLayerPanel.java (modified) (2 diffs)
• AddWMTSLayerPanel.java (modified) (2 diffs)
• HeadersTable.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/AddWMSLayerPanel.java

@@ -42 +42 @@
     private final transient WMSLayerTree tree = new WMSLayerTree();
     private final JComboBox<String> formats = new JComboBox<>();
-    private final JLabel wmsInstruction;
     private final JosmTextArea wmsUrl = new JosmTextArea(3, 40).transferFocusOnTab();
     private final JButton showBounds = new JButton(tr("Show bounds"));
@@ -73 +72 @@
         addCommonSettings();
 
-        wmsInstruction = new JLabel(tr("{0} Edit generated {1} URL (optional)", "6.", "WMS"));
+        JLabel wmsInstruction = new JLabel(tr("{0} Edit generated {1} URL (optional)", "6.", "WMS"));
         add(wmsInstruction, GBC.eol());
         wmsInstruction.setLabelFor(wmsUrl);

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/AddWMTSLayerPanel.java

@@ -46 +46 @@
         JButton getLayers = new JButton(tr("{0} Get layers", "3."));
         getLayers.setEnabled(setDefaultLayer.isSelected());
-        setDefaultLayer.addActionListener(e -> {
-                getLayers.setEnabled(setDefaultLayer.isSelected());
-        });
+        setDefaultLayer.addActionListener(e -> getLayers.setEnabled(setDefaultLayer.isSelected()));
         add(setDefaultLayer, GBC.eop());
         add(getLayers, GBC.eop().fill(GBC.HORIZONTAL));
@@ -76 +74 @@
                 layerPanel.revalidate();
             } catch (IOException | WMTSGetCapabilitiesException ex) {
+                Logging.trace(ex);
                 JOptionPane.showMessageDialog(
                         getParent(),

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/HeadersTable.java

@@ -81 +81 @@
     }
 
-    private final JTable table;
     private List<String[]> headers;
 
@@ -98 +97 @@
         super(new GridBagLayout());
         this.headers = getHeadersAsVector(headers);
-        table = new JTable(new HeaderTableModel());
+        JTable table = new JTable(new HeaderTableModel());
         table.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
         table.setAutoCreateRowSorter(true);