Changeset 13795 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2018-05-20T22:02:51+02:00 (6 years ago)

Author:

Don-vip

Message:

fix #13561, fix #16265 - fix mapmode change issues with "Adjust imagery offset"

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/ImageryAdjustAction.java (modified) (1 diff)
• gui/MapFrame.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -127 +127 @@
     private void doExitMode() {
         exitingMode = true;
-        super.exitMode();
+        try {
+            super.exitMode();
+        } catch (IllegalArgumentException e) {
+            Logging.trace(e);
+        }
         if (offsetDialog != null) {
             if (layer != null) {

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -471 +471 @@
      */
     public boolean selectMapMode(MapMode newMapMode, Layer newLayer) {
-        if (newMapMode == null || !newMapMode.layerIsSupported(newLayer))
-            return false;
-
         MapMode oldMapMode = this.mapMode;
         if (newMapMode == oldMapMode)
             return true;
+        if (newMapMode == null || !newMapMode.layerIsSupported(newLayer)) {
+            newMapMode = null;
+        }
+
         if (oldMapMode != null) {
             oldMapMode.exitMode();
         }
         this.mapMode = newMapMode;
-        newMapMode.enterMode();
+        if (newMapMode != null) {
+            newMapMode.enterMode();
+        }
         lastMapMode.put(newLayer, newMapMode);
         fireMapModeChanged(oldMapMode, newMapMode);
-        return true;
+        return newMapMode != null;
     }