Changeset 13414 in josm for trunk/src/org/openstreetmap/josm/actions

Timestamp:

2018-02-12T02:31:14+01:00 (22 months ago)

Author:

Don-vip

Message:

fix #15452 - More details are needed for "Tag value longer than allowed" (patch by Klumbumbus, modified)

File:

• trunk/src/org/openstreetmap/josm/actions/upload/ApiPreconditionCheckerHook.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/upload/ApiPreconditionCheckerHook.java

@@ -12 +12 @@
 import org.openstreetmap.josm.data.APIDataSet;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.data.osm.Tagged;
 import org.openstreetmap.josm.data.osm.Way;
 import org.openstreetmap.josm.gui.ExceptionDialogUtil;
@@ -61 +62 @@
             for (String key: osmPrimitive.keySet()) {
                 String value = osmPrimitive.get(key);
-                if (key.length() > 255) {
+                if (key.length() > Tagged.MAX_TAG_LENGTH) {
                     if (osmPrimitive.isDeleted()) {
                         // if OsmPrimitive is going to be deleted we automatically shorten the value
@@ -70 +71 @@
                                 )
                         );
-                        osmPrimitive.put(key, value.substring(0, 255));
+                        osmPrimitive.put(key, value.substring(0, Tagged.MAX_TAG_LENGTH));
                         continue;
                     }
                     JOptionPane.showMessageDialog(Main.parent,
                             tr("Length of value for tag ''{0}'' on object {1} exceeds the max. allowed length {2}. Values length is {3}.",
-                                    key, Long.toString(osmPrimitive.getId()), 255, value.length()
+                                    key, Long.toString(osmPrimitive.getId()), Tagged.MAX_TAG_LENGTH, value.length()
                             ),
                             tr("Precondition Violation"),