Changeset 12903 in josm for trunk/src/org/openstreetmap/josm/gui/download/OverpassDownloadSource.java

Timestamp:

2017-09-26T21:52:28+02:00 (7 years ago)

Author:

Don-vip

Message:

fix #15267 - fix various usability problems with new download dialog

File:

• trunk/src/org/openstreetmap/josm/gui/download/OverpassDownloadSource.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/download/OverpassDownloadSource.java

@@ -8 +8 @@
 import java.awt.GridBagLayout;
 import java.awt.event.ActionEvent;
+import java.awt.event.FocusAdapter;
 import java.awt.event.FocusEvent;
-import java.awt.event.FocusListener;
 import java.util.Collection;
 import java.util.concurrent.Future;
@@ -15 +15 @@
 
 import javax.swing.AbstractAction;
-import javax.swing.Action;
 import javax.swing.Icon;
 import javax.swing.JButton;
@@ -32 +31 @@
 import org.openstreetmap.josm.data.preferences.BooleanProperty;
 import org.openstreetmap.josm.data.preferences.IntegerProperty;
+import org.openstreetmap.josm.data.preferences.StringProperty;
 import org.openstreetmap.josm.gui.ConditionalOptionPaneUtil;
 import org.openstreetmap.josm.gui.MainApplication;
@@ -90 +90 @@
         private static final String ACTION_IMG_SUBDIR = "dialogs";
 
+        private static final StringProperty DOWNLOAD_QUERY = new StringProperty("download.overpass.query",
+                "/*\n" + tr("Place your Overpass query below or generate one using the Overpass Turbo Query Wizard") + "\n*/");
+
         private final JosmTextArea overpassQuery;
         private final UserQueryList overpassQueryList;
@@ -102 +105 @@
 
             String tooltip = tr("Build an Overpass query using the Overpass Turbo Query Wizard tool");
-            Action queryWizardAction = new AbstractAction() {
+
+            JButton openQueryWizard = new JButton(tr("Query Wizard"));
+            openQueryWizard.setToolTipText(tooltip);
+            openQueryWizard.addActionListener(new AbstractAction() {
                 @Override
                 public void actionPerformed(ActionEvent e) {
                     new OverpassQueryWizardDialog(OverpassDownloadSourcePanel.this).showDialog();
                 }
-            };
-
-            JButton openQueryWizard = new JButton(tr("Query Wizard"));
-            openQueryWizard.setToolTipText(tooltip);
-            openQueryWizard.addActionListener(queryWizardAction);
-
-            // CHECKSTYLE.OFF: LineLength
-            this.overpassQuery = new JosmTextArea(
-                    "/*\n" +
-                            tr("Place your Overpass query below or generate one using the Overpass Turbo Query Wizard")
-                            + "\n*/",
-                    8, 80);
-            // CHECKSTYLE.ON: LineLength
+            });
+
+            this.overpassQuery = new JosmTextArea(DOWNLOAD_QUERY.get(), 8, 80);
             this.overpassQuery.setFont(GuiHelper.getMonospacedFont(overpassQuery));
-            this.overpassQuery.addFocusListener(new FocusListener() {
+            this.overpassQuery.addFocusListener(new FocusAdapter() {
                 @Override
                 public void focusGained(FocusEvent e) {
                     overpassQuery.selectAll();
                 }
-
-                @Override
-                public void focusLost(FocusEvent e) {
-                    // ignored
-                }
             });
-
 
             this.overpassQueryList = new UserQueryList(this, this.overpassQuery, "download.overpass.query");
@@ -207 +197 @@
         @Override
         public void rememberSettings() {
-            // nothing
+            DOWNLOAD_QUERY.put(overpassQuery.getText());
         }
 
         @Override
         public void restoreSettings() {
-            // nothing
+            overpassQuery.setText(DOWNLOAD_QUERY.get());
         }