Changeset 12857 in josm for trunk/src/org/openstreetmap/josm/data

Timestamp:

2017-09-14T16:19:17+02:00 (7 years ago)

Author:

bastiK

Message:

see #15229 - fix bug where parameter createIfMissing would be ignored because of caching

File:

• trunk/src/org/openstreetmap/josm/data/Preferences.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -340 +340 @@
     @Override
     public File getPreferencesDirectory(boolean createIfMissing) {
-        if (preferencesDir != null)
-            return preferencesDir;
-        String path;
-        path = System.getProperty("josm.pref");
-        if (path != null) {
-            preferencesDir = new File(path).getAbsoluteFile();
-        } else {
-            path = System.getProperty("josm.home");
+        if (preferencesDir == null) {
+            String path;
+            path = System.getProperty("josm.pref");
             if (path != null) {
                 preferencesDir = new File(path).getAbsoluteFile();
             } else {
-                preferencesDir = Main.platform.getDefaultPrefDirectory();
+                path = System.getProperty("josm.home");
+                if (path != null) {
+                    preferencesDir = new File(path).getAbsoluteFile();
+                } else {
+                    preferencesDir = Main.platform.getDefaultPrefDirectory();
+                }
             }
         }
@@ -380 +380 @@
     @Override
     public File getUserDataDirectory(boolean createIfMissing) {
-        if (userdataDir != null)
-            return userdataDir;
-        String path;
-        path = System.getProperty("josm.userdata");
-        if (path != null) {
-            userdataDir = new File(path).getAbsoluteFile();
-        } else {
-            path = System.getProperty("josm.home");
+        if (userdataDir == null) {
+            String path;
+            path = System.getProperty("josm.userdata");
             if (path != null) {
                 userdataDir = new File(path).getAbsoluteFile();
             } else {
-                userdataDir = Main.platform.getDefaultUserDataDirectory();
+                path = System.getProperty("josm.home");
+                if (path != null) {
+                    userdataDir = new File(path).getAbsoluteFile();
+                } else {
+                    userdataDir = Main.platform.getDefaultUserDataDirectory();
+                }
             }
         }
@@ -445 +445 @@
     @Override
     public File getCacheDirectory(boolean createIfMissing) {
-        if (cacheDir != null)
-            return cacheDir;
-        String path = System.getProperty("josm.cache");
-        if (path != null) {
-            cacheDir = new File(path).getAbsoluteFile();
-        } else {
-            path = System.getProperty("josm.home");
+        if (cacheDir == null) {
+            String path = System.getProperty("josm.cache");
             if (path != null) {
-                cacheDir = new File(path, "cache");
+                cacheDir = new File(path).getAbsoluteFile();
             } else {
-                path = get("cache.folder", null);
+                path = System.getProperty("josm.home");
                 if (path != null) {
-                    cacheDir = new File(path).getAbsoluteFile();
+                    cacheDir = new File(path, "cache");
                 } else {
-                    cacheDir = Main.platform.getDefaultCacheDirectory();
+                    path = get("cache.folder", null);
+                    if (path != null) {
+                        cacheDir = new File(path).getAbsoluteFile();
+                    } else {
+                        cacheDir = Main.platform.getDefaultCacheDirectory();
+                    }
                 }
             }