Changeset 12638 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2017-08-25T00:57:47+02:00 (7 years ago)

Author:

Don-vip

Message:

see #15182 - remove Main.currentProgressMonitor. Replacement: PleaseWaitProgressMonitor.getCurrent()

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (3 diffs)
• gui/MainApplication.java (modified) (2 diffs)
• gui/MainPanel.java (modified) (2 diffs)
• gui/MapStatus.java (modified) (1 diff)
• gui/progress/PleaseWaitProgressMonitor.java (modified) (4 diffs)
• gui/progress/ProgressMonitorExecutor.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/Main.java

@@ -48 +48 @@
 import org.openstreetmap.josm.gui.MapFrameListener;
 import org.openstreetmap.josm.gui.layer.MainLayerManager;
-import org.openstreetmap.josm.gui.layer.OsmDataLayer.CommandQueueListener;
 import org.openstreetmap.josm.gui.preferences.ToolbarPreferences;
 import org.openstreetmap.josm.gui.preferences.projection.ProjectionPreference;
-import org.openstreetmap.josm.gui.progress.PleaseWaitProgressMonitor;
 import org.openstreetmap.josm.io.FileWatcher;
 import org.openstreetmap.josm.io.OnlineResource;
@@ -147 +145 @@
 
     /**
-     * The progress monitor being currently displayed.
-     */
-    public static PleaseWaitProgressMonitor currentProgressMonitor;
-
-    /**
      * The main menu bar at top of screen.
      */
@@ -726 +719 @@
     //  Implementation part
     ///////////////////////////////////////////////////////////////////////////
-
-    /**
-     * Listener that sets the enabled state of undo/redo menu entries.
-     */
-    protected final CommandQueueListener redoUndoListener = (queueSize, redoSize) -> {
-            menu.undo.setEnabled(queueSize > 0);
-            menu.redo.setEnabled(redoSize > 0);
-        };
 
     /**

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -76 +76 @@
 import org.openstreetmap.josm.gui.layer.AutosaveTask;
 import org.openstreetmap.josm.gui.layer.MainLayerManager;
+import org.openstreetmap.josm.gui.layer.OsmDataLayer.CommandQueueListener;
 import org.openstreetmap.josm.gui.layer.TMSLayer;
 import org.openstreetmap.josm.gui.preferences.ToolbarPreferences;
@@ -152 +153 @@
      */
     private static final MainLayerManager layerManager = new MainLayerManager();
+
+    /**
+     * Listener that sets the enabled state of undo/redo menu entries.
+     */
+    private final CommandQueueListener redoUndoListener = (queueSize, redoSize) -> {
+            menu.undo.setEnabled(queueSize > 0);
+            menu.redo.setEnabled(redoSize > 0);
+        };
 
     /**

trunk/src/org/openstreetmap/josm/gui/MainPanel.java

@@ -14 +14 @@
 import org.openstreetmap.josm.gui.layer.MainLayerManager.LayerAvailabilityEvent;
 import org.openstreetmap.josm.gui.layer.MainLayerManager.LayerAvailabilityListener;
+import org.openstreetmap.josm.gui.progress.PleaseWaitProgressMonitor;
 import org.openstreetmap.josm.gui.util.GuiHelper;
 
@@ -80 +81 @@
             listener.mapFrameInitialized(old, map);
         }
-        if (map == null && Main.currentProgressMonitor != null) {
-            Main.currentProgressMonitor.showForegroundDialog();
+        if (map == null && PleaseWaitProgressMonitor.getCurrent() != null) {
+            PleaseWaitProgressMonitor.getCurrent().showForegroundDialog();
         }
     }

trunk/src/org/openstreetmap/josm/gui/MapStatus.java

@@ -139 +139 @@
         @Override
         public void mouseClicked(MouseEvent e) {
-            PleaseWaitProgressMonitor monitor = Main.currentProgressMonitor;
+            PleaseWaitProgressMonitor monitor = PleaseWaitProgressMonitor.getCurrent();
             if (monitor != null) {
                 monitor.showForegroundDialog();

trunk/src/org/openstreetmap/josm/gui/progress/PleaseWaitProgressMonitor.java

@@ -73 +73 @@
      */
     public static final int PROGRESS_BAR_MAX = 10_000;
+
+    /**
+     * The progress monitor being currently displayed.
+     */
+    static PleaseWaitProgressMonitor currentProgressMonitor;
+
     private final Component dialogParent;
 
@@ -86 +92 @@
 
     private boolean cancelable;
+
+    /**
+     * Returns the progress monitor being currently displayed.
+     * @return the progress monitor being currently displayed
+     * @since 12638
+     */
+    public static PleaseWaitProgressMonitor getCurrent() {
+        return currentProgressMonitor;
+    }
 
     private void doInEDT(Runnable runnable) {
@@ -215 +230 @@
     public void doBeginTask() {
         doInEDT(() -> {
-            Main.currentProgressMonitor = this;
+            currentProgressMonitor = this;
             if (GraphicsEnvironment.isHeadless()) {
                 return;
@@ -339 +354 @@
                 dialog.dispose();
                 dialog = null;
-                Main.currentProgressMonitor = null;
+                currentProgressMonitor = null;
                 MapFrame map = MainApplication.getMap();
                 if (map != null) {

trunk/src/org/openstreetmap/josm/gui/progress/ProgressMonitorExecutor.java

@@ -6 +6 @@
 import java.util.concurrent.TimeUnit;
 
-import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.tools.Utils;
 
@@ -30 +29 @@
     @Override
     public void execute(Runnable command) {
-        if (Main.currentProgressMonitor != null) {
+        if (PleaseWaitProgressMonitor.currentProgressMonitor != null) {
             //TODO show only if this can't be in background or better if always in background is not checked
-            Main.currentProgressMonitor.showForegroundDialog();
+            PleaseWaitProgressMonitor.currentProgressMonitor.showForegroundDialog();
         }
         super.execute(command);