Ignore:
Timestamp:
2017-07-30T00:22:46+02:00 (2 years ago)
Author:
Don-vip
Message:

PMD - VariableNamingConventions

Location:
trunk/src/org/openstreetmap/josm/data/osm
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/data/osm/ChangesetCache.java

    r11349 r12537  
    3737public final class ChangesetCache implements PreferenceChangedListener {
    3838    /** the unique instance */
    39     private static final ChangesetCache instance = new ChangesetCache();
     39    private static final ChangesetCache INSTANCE = new ChangesetCache();
    4040
    4141    /** the cached changesets */
     
    5656     */
    5757    public static ChangesetCache getInstance() {
    58         return instance;
     58        return INSTANCE;
    5959    }
    6060
  • trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

    r12479 r12537  
    638638     * dataset. (However, the selection does only change in the active layer)
    639639     */
    640     private static final Collection<SelectionChangedListener> selListeners = new CopyOnWriteArrayList<>();
     640    private static final Collection<SelectionChangedListener> SEL_LISTENERS = new CopyOnWriteArrayList<>();
    641641
    642642    /**
     
    647647     */
    648648    public static void addSelectionListener(SelectionChangedListener listener) {
    649         ((CopyOnWriteArrayList<SelectionChangedListener>) selListeners).addIfAbsent(listener);
     649        ((CopyOnWriteArrayList<SelectionChangedListener>) SEL_LISTENERS).addIfAbsent(listener);
    650650    }
    651651
     
    657657     */
    658658    public static void removeSelectionListener(SelectionChangedListener listener) {
    659         selListeners.remove(listener);
     659        SEL_LISTENERS.remove(listener);
    660660    }
    661661
     
    671671
    672672    private static void fireDreprecatedSelectionChange(Collection<? extends OsmPrimitive> currentSelection) {
    673         for (SelectionChangedListener l : selListeners) {
     673        for (SelectionChangedListener l : SEL_LISTENERS) {
    674674            l.selectionChanged(currentSelection);
    675675        }
  • trunk/src/org/openstreetmap/josm/data/osm/QuadBuckets.java

    r12122 r12537  
    2323 */
    2424public class QuadBuckets<T extends OsmPrimitive> implements Collection<T> {
    25     private static final boolean consistency_testing = false;
     25    private static final boolean CONSISTENCY_TESTING = false;
    2626    private static final byte NW_INDEX = 1;
    2727    private static final byte NE_INDEX = 3;
     
    271271
    272272        void doAdd(T o) {
    273             if (consistency_testing) {
     273            if (CONSISTENCY_TESTING) {
    274274                if (o instanceof Node && !matches(o, this)) {
    275275                    o.getBBox().getIndex(level);
  • trunk/src/org/openstreetmap/josm/data/osm/User.java

    r11912 r12537  
    3434     * @see #getAnonymous()
    3535     */
    36     private static final User anonymous = createLocalUser(tr("<anonymous>"));
     36    private static final User ANONYMOUS = createLocalUser(tr("<anonymous>"));
    3737
    3838    private static long getNextLocalUid() {
     
    131131     */
    132132    public static User getAnonymous() {
    133         return anonymous;
     133        return ANONYMOUS;
    134134    }
    135135
  • trunk/src/org/openstreetmap/josm/data/osm/event/DatasetEventManager.java

    r11928 r12537  
    2929public class DatasetEventManager implements ActiveLayerChangeListener, Listener {
    3030
    31     private static final DatasetEventManager instance = new DatasetEventManager();
     31    private static final DatasetEventManager INSTANCE = new DatasetEventManager();
    3232
    3333    private final class EdtRunnable implements Runnable {
     
    139139     */
    140140    public static DatasetEventManager getInstance() {
    141         return instance;
     141        return INSTANCE;
    142142    }
    143143
  • trunk/src/org/openstreetmap/josm/data/osm/event/SelectionEventManager.java

    r12116 r12537  
    3232public class SelectionEventManager implements DataSelectionListener, ActiveLayerChangeListener {
    3333
    34     private static final SelectionEventManager instance = new SelectionEventManager();
     34    private static final SelectionEventManager INSTANCE = new SelectionEventManager();
    3535
    3636    /**
     
    3939     */
    4040    public static SelectionEventManager getInstance() {
    41         return instance;
     41        return INSTANCE;
    4242    }
    4343
  • trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/PaintColors.java

    r12376 r12537  
    9393    private static volatile Color backgroundColorCache;
    9494
    95     private static final MapPaintSylesUpdateListener styleOverrideListener = new MapPaintSylesUpdateListener() {
     95    private static final MapPaintSylesUpdateListener STYLE_OVERRIDE_LISTENER = new MapPaintSylesUpdateListener() {
    9696        //TODO: Listen to wireframe map mode changes.
    9797        @Override
     
    107107
    108108    static {
    109         MapPaintStyles.addMapPaintSylesUpdateListener(styleOverrideListener);
     109        MapPaintStyles.addMapPaintSylesUpdateListener(STYLE_OVERRIDE_LISTENER);
    110110    }
    111111
Note: See TracChangeset for help on using the changeset viewer.