Changeset 12537 in josm for trunk/src/org/openstreetmap/josm/corrector

Timestamp:

2017-07-30T00:22:46+02:00 (2 years ago)

Author:

Don-vip

Message:

PMD - VariableNamingConventions

Location:

trunk/src/org/openstreetmap/josm/corrector

Files:

• ReverseWayNoTagCorrector.java (modified) (2 diffs)
• ReverseWayTagCorrector.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/corrector/ReverseWayNoTagCorrector.java

@@ -36 +36 @@
      * Tags that imply a semantic meaning from the way direction and cannot be changed.
      */
-    private static final TagCollection directionalTags = new TagCollection(Arrays.asList(
+    private static final TagCollection DIRECTIONAL_TAGS = new TagCollection(Arrays.asList(
             new Tag("natural", "coastline"),
             new Tag("natural", "cliff"),
@@ -54 +54 @@
         for (Map.Entry<String, String> entry : way.getKeys().entrySet()) {
             final Tag tag = new Tag(entry.getKey(), entry.getValue());
-            final boolean isDirectional = directionalTags.contains(tag) || tag.isDirectionKey();
+            final boolean isDirectional = DIRECTIONAL_TAGS.contains(tag) || tag.isDirectionKey();
             if (isDirectional) {
                 final boolean cannotBeCorrected = ReverseWayTagCorrector.getTagCorrections(tag).isEmpty();

trunk/src/org/openstreetmap/josm/corrector/ReverseWayTagCorrector.java

@@ -53 +53 @@
     }
 
-    private static final Collection<Pattern> ignoredKeys = new ArrayList<>();
+    private static final Collection<Pattern> IGNORED_KEYS = new ArrayList<>();
     static {
         for (String s : OsmPrimitive.getUninterestingKeys()) {
-            ignoredKeys.add(getPatternFor(s));
+            IGNORED_KEYS.add(getPatternFor(s));
         }
         for (String s : new String[]{"name", "ref", "tiger:county"}) {
-            ignoredKeys.add(getPatternFor(s, false));
+            IGNORED_KEYS.add(getPatternFor(s, false));
         }
         for (String s : new String[]{"tiger:county", "turn:lanes", "change:lanes", "placement"}) {
-            ignoredKeys.add(getPatternFor(s, true));
+            IGNORED_KEYS.add(getPatternFor(s, true));
         }
     }
@@ -292 +292 @@
 
     private static boolean ignoreKeyForCorrection(String key) {
-        for (Pattern ignoredKey : ignoredKeys) {
+        for (Pattern ignoredKey : IGNORED_KEYS) {
             if (ignoredKey.matcher(key).matches()) {
                 return true;