Changeset 12403 in josm

Timestamp:

2017-06-12T00:19:19+02:00 (7 years ago)

Author:

Don-vip

Message:

see #14929 - findbugs

Location:

trunk/src/org/openstreetmap/josm/gui/autofilter

Files:

• AutoFilterManager.java (modified) (2 diffs)
• AutoFilterRule.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/autofilter/AutoFilterManager.java

@@ -58 +58 @@
      * Property to determines if the auto filter feature is enabled.
      */
-    public static BooleanProperty PROP_AUTO_FILTER_ENABLED = new BooleanProperty("auto.filter.enabled", Boolean.TRUE);
+    public static final BooleanProperty PROP_AUTO_FILTER_ENABLED = new BooleanProperty("auto.filter.enabled", Boolean.TRUE);
 
     /**
      * Property to determine the current auto filter rule.
      */
-    public static StringProperty PROP_AUTO_FILTER_RULE = new StringProperty("auto.filter.rule", "level");
+    public static final StringProperty PROP_AUTO_FILTER_RULE = new StringProperty("auto.filter.rule", "level");
 
     /**
      * The unique instance.
      */
-    private static AutoFilterManager instance;
+    private static volatile AutoFilterManager instance;
 
     /**
@@ -319 +319 @@
      * @return the currently selected auto filter, or null
      */
-    public AutoFilter getCurrentAutoFilter() {
+    public synchronized AutoFilter getCurrentAutoFilter() {
         return currentAutoFilter;
     }

trunk/src/org/openstreetmap/josm/gui/autofilter/AutoFilterRule.java

@@ -21 +21 @@
     private Function<String, String> valueFormatter = s -> s;
 
-    private Comparator<String> valueComparator = Comparator.comparingInt(s -> Integer.valueOf(valueFormatter.apply(s)));
+    private Comparator<String> valueComparator = Comparator.comparingInt(s -> Integer.parseInt(valueFormatter.apply(s)));
 
     /**
@@ -99 +99 @@
             new AutoFilterRule("voltage", 5)
                 .setValueFormatter(s -> s.replaceAll("000$", "k") + 'V')
-                .setValueComparator(Comparator.comparingInt(s -> Integer.valueOf(s)))
+                .setValueComparator(Comparator.comparingInt(s -> Integer.parseInt(s)))
         };
     }