Changeset 12365 in josm for trunk/src/org/openstreetmap/josm/actions/upload/RelationUploadOrderHook.java

Timestamp:

2017-06-09T19:57:55+02:00 (7 years ago)

Author:

michael2402

Message:

CyclicUploadDependencyException: Copy the collection passed to the constructor. Fix squid:S1149

File:

• trunk/src/org/openstreetmap/josm/actions/upload/RelationUploadOrderHook.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/upload/RelationUploadOrderHook.java

@@ -6 +6 @@
 import java.awt.BorderLayout;
 import java.awt.Dimension;
+import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
@@ -66 +67 @@
      */
     protected void warnCyclicUploadDependency(CyclicUploadDependencyException e) {
-        List<Relation> dep = e.getCyclicUploadDependency();
+        List<Relation> dep = new ArrayList<>(e.getCyclicUploadDependency());
         Relation last = dep.get(dep.size() -1);
         Iterator<Relation> it = dep.iterator();