Changeset 12352 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictDialog.java

Timestamp:

2017-06-09T00:14:12+02:00 (7 years ago)

Author:

michael2402

Message:

Use new selection interface in ConflictDialog

The dialog is now not confused by any selection changes that happen in the non-edit layers (e.g. because of undo)

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictDialog.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictDialog.java

@@ -41 +41 @@
 import org.openstreetmap.josm.command.Command;
 import org.openstreetmap.josm.command.SequenceCommand;
-import org.openstreetmap.josm.data.SelectionChangedListener;
 import org.openstreetmap.josm.data.conflict.Conflict;
 import org.openstreetmap.josm.data.conflict.ConflictCollection;
 import org.openstreetmap.josm.data.conflict.IConflictListener;
+import org.openstreetmap.josm.data.osm.DataSelectionListener;
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.Node;
@@ -75 +75 @@
  * @since 86
  */
-public final class ConflictDialog extends ToggleDialog implements ActiveLayerChangeListener, IConflictListener, SelectionChangedListener {
+public final class ConflictDialog extends ToggleDialog implements ActiveLayerChangeListener, IConflictListener, DataSelectionListener {
 
     private static final ColorProperty CONFLICT_COLOR = new ColorProperty(marktr("conflict"), Color.GRAY);
@@ -151 +151 @@
     @Override
     public void showNotify() {
-        DataSet.addSelectionListener(this);
         Main.getLayerManager().addAndFireActiveLayerChangeListener(this);
         refreshView();
@@ -159 +158 @@
     public void hideNotify() {
         Main.getLayerManager().removeActiveLayerChangeListener(this);
-        DataSet.removeSelectionListener(this);
+        OsmDataLayer editLayer = Main.getLayerManager().getEditLayer();
+        removeEditLayerListeners(editLayer);
     }
 
@@ -259 +259 @@
     @Override
     public void activeOrEditLayerChanged(ActiveLayerChangeEvent e) {
-        OsmDataLayer oldLayer = e.getPreviousEditLayer();
+        removeEditLayerListeners(e.getPreviousEditLayer());
+        addEditLayerListeners(e.getSource().getEditLayer());
+        refreshView();
+    }
+
+    private void addEditLayerListeners(OsmDataLayer newLayer) {
+        if (newLayer != null) {
+            newLayer.getConflicts().addConflictListener(this);
+            newLayer.data.addSelectionListener(this);
+        }
+    }
+
+    private void removeEditLayerListeners(OsmDataLayer oldLayer) {
         if (oldLayer != null) {
             oldLayer.getConflicts().removeConflictListener(this);
-        }
-        OsmDataLayer newLayer = e.getSource().getEditLayer();
-        if (newLayer != null) {
-            newLayer.getConflicts().addConflictListener(this);
-        }
-        refreshView();
+            oldLayer.data.removeSelectionListener(this);
+        }
     }
 
@@ -310 +318 @@
 
     @Override
-    public void selectionChanged(Collection<? extends OsmPrimitive> newSelection) {
+    public void selectionChanged(SelectionChangeEvent event) {
         lstConflicts.setValueIsAdjusting(true);
         lstConflicts.clearSelection();
-        for (OsmPrimitive osm : newSelection) {
+        for (OsmPrimitive osm : event.getSelection()) {
             if (conflicts != null && conflicts.hasConflictForMy(osm)) {
                 int pos = model.indexOf(osm);