Changeset 1217 in josm for trunk/src/org/openstreetmap/josm/actions

Timestamp:

2009-01-09T01:00:19+01:00 (15 years ago)

Author:

ulfl

Message:

if nothing is selected, show a dialog box

File:

• trunk/src/org/openstreetmap/josm/actions/HistoryInfoAction.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/HistoryInfoAction.java

@@ -6 +6 @@
 import java.awt.event.ActionEvent;
 import java.awt.event.KeyEvent;
+import java.util.Collection;
+import java.util.LinkedList;
+
+import javax.swing.JOptionPane;
 
 import org.openstreetmap.josm.Main;
@@ -19 +23 @@
 
     public HistoryInfoAction() {
-        super(tr("OSM History Information"), "about",tr("Display history information about OSM ways or nodes."),
-        Shortcut.registerShortcut("core:history", tr("OSM History Information"), KeyEvent.VK_H, Shortcut.GROUP_HOTKEY), true);
+        super(tr("History of Node/Way"), "about",tr("Display history information about OSM ways or nodes."),
+        Shortcut.registerShortcut("core:history", tr("History of Node/Way"), KeyEvent.VK_H, Shortcut.GROUP_HOTKEY), true);
     }
 
     public void actionPerformed(ActionEvent e) {
+                final Collection<Object> sel = new LinkedList<Object>();
                 new Visitor() {
                         public void visit(Node n) {
-                OpenBrowser.displayUrl("http://www.openstreetmap.org/browse/node/" + n.id + "/history");
-            }
+                                OpenBrowser.displayUrl("http://www.openstreetmap.org/browse/node/" + n.id + "/history");
+                                sel.add(n);
+                        }
 
                         public void visit(Way w) {
                                 OpenBrowser.displayUrl("http://www.openstreetmap.org/browse/way/" + w.id + "/history");
+                                sel.add(w);
                         }
 
                         public void visit(Relation e) {
-                              OpenBrowser.displayUrl("http://www.openstreetmap.org/browse/relation/" + e.id + "/history");
+                                OpenBrowser.displayUrl("http://www.openstreetmap.org/browse/relation/" + e.id + "/history");
+                                sel.add(e);
                         }
 
@@ -43 +51 @@
                 }.visitAll();
 
+                if (sel.isEmpty()) {
+                                        JOptionPane.showMessageDialog(Main.parent,
+                                                        tr("Please select at least one node or way."));
+                                        return;
+                }
     }