Changeset 12107 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2017-05-11T00:18:12+02:00 (7 years ago)

Author:

michael2402

Message:

Allow invalidation listeners for all MapViewPaintables.

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• MapView.java (modified) (3 diffs)
• layer/AbstractMapViewPaintable.java (modified) (1 diff)
• layer/MapViewPaintable.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -52 +52 @@
 import org.openstreetmap.josm.gui.MapViewState.MapViewRectangle;
 import org.openstreetmap.josm.gui.datatransfer.OsmTransferHandler;
-import org.openstreetmap.josm.gui.layer.AbstractMapViewPaintable;
 import org.openstreetmap.josm.gui.layer.GpxLayer;
 import org.openstreetmap.josm.gui.layer.ImageryLayer;
@@ -124 +123 @@
          */
         public synchronized void addTo(MapViewPaintable p) {
-            if (p instanceof AbstractMapViewPaintable) {
-                ((AbstractMapViewPaintable) p).addInvalidationListener(this);
-            }
+            p.addInvalidationListener(this);
         }
 
@@ -134 +131 @@
          */
         public synchronized void removeFrom(MapViewPaintable p) {
-            if (p instanceof AbstractMapViewPaintable) {
-                ((AbstractMapViewPaintable) p).removeInvalidationListener(this);
-            }
+            p.removeInvalidationListener(this);
             invalidatedLayers.remove(p);
         }

trunk/src/org/openstreetmap/josm/gui/layer/AbstractMapViewPaintable.java

@@ -70 +70 @@
     }
 
-    /**
-     * Adds a new paintable invalidation listener.
-     * @param l The listener to add.
-     */
+    @Override
     public void addInvalidationListener(PaintableInvalidationListener l) {
         invalidationListeners.add(l);
     }
 
-    /**
-     * Removes an added paintable invalidation listener.
-     * @param l The listener to remove.
-     */
+    @Override
     public void removeInvalidationListener(PaintableInvalidationListener l) {
         invalidationListeners.remove(l);

trunk/src/org/openstreetmap/josm/gui/layer/MapViewPaintable.java

@@ -142 +142 @@
      */
     void paint(Graphics2D g, MapView mv, Bounds bbox);
+
+    /**
+     * Adds a new paintable invalidation listener.
+     * @param l The listener to add.
+     * @since 12107
+     */
+    default void addInvalidationListener(PaintableInvalidationListener l) {
+    }
+
+    /**
+     * Removes an added paintable invalidation listener. May throw an exception if the listener is added twice.
+     * @param l The listener to remove.
+     * @since 12107
+     */
+    default void removeInvalidationListener(PaintableInvalidationListener l) {
+    }
+
 }