Changeset 12057 in josm for trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

Timestamp:

2017-05-03T22:19:58+02:00 (7 years ago)

Author:

michael2402

Message:

Make cleanupDeletedPrimitives code nicer, only use one bulk update

File:

• trunk/src/org/openstreetmap/josm/data/osm/DataSet.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -22 +22 @@
 import java.util.function.Function;
 import java.util.function.Predicate;
-import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
@@ -575 +574 @@
             if (primitive == null)
                 return;
+            clearSelection(primitiveId);
             super.removePrimitive(primitive);
-            clearSelection(primitiveId);
             allPrimitives.remove(primitive);
             primitive.setDataset(null);
@@ -1246 +1245 @@
         beginUpdate();
         try {
-            cleanupDeleted(Stream.concat(
-                    getNodes().stream(), Stream.concat(getNodes().stream(), getNodes().stream())));
+            Collection<OsmPrimitive> toCleanUp = getPrimitives(primitive -> primitive.isDeleted() && (!primitive.isVisible() || primitive.isNew()));
+            if (!toCleanUp.isEmpty()) {
+                clearSelection(toCleanUp.stream().map(OsmPrimitive::getPrimitiveId));
+                for (OsmPrimitive primitive : toCleanUp) {
+                    allPrimitives.remove(primitive);
+                    removePrimitive(primitive);
+                    primitive.setDataset(null);
+                }
+                firePrimitivesRemoved(toCleanUp, false);
+            }
         } finally {
             endUpdate();
         }
-    }
-
-    private void cleanupDeleted(Stream<? extends OsmPrimitive> it) {
-        it.filter(primitive -> primitive.isDeleted() && (!primitive.isVisible() || primitive.isNew()))
-                .collect(Collectors.toList())
-                .forEach(primitive -> this.removePrimitive(primitive.getPrimitiveId()));
-
     }