Changeset 12034 in josm for trunk/test/unit/org/openstreetmap/josm/data

Timestamp:

2017-05-01T14:32:35+02:00 (7 years ago)

Author:

Don-vip

Message:

add more unit tests

File:

• trunk/test/unit/org/openstreetmap/josm/data/osm/ChangesetCacheTest.java (modified) (6 diffs)

trunk/test/unit/org/openstreetmap/josm/data/osm/ChangesetCacheTest.java

@@ -7 +7 @@
 import static org.junit.Assert.assertTrue;
 
+import java.util.Arrays;
+import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
 
-import org.junit.Assert;
+import org.junit.After;
 import org.junit.Test;
 import org.openstreetmap.josm.TestUtils;
+import org.openstreetmap.josm.gui.JosmUserIdentityManager;
 
 /**
@@ -18 +21 @@
  */
 public class ChangesetCacheTest {
+
+    /**
+     * Clears cache after each unit test.
+     */
+    @After
+    public void after() {
+        ChangesetCache.getInstance().clear();
+    }
 
     /**
@@ -184 +195 @@
 
     /**
-     * Unit test of method {@link ChangesetCache#getOpenChangesets}.
+     * Unit test of methods {@link ChangesetCache#getOpenChangesets} / {@link ChangesetCache#getChangesets}.
      */
     @Test
@@ -190 +201 @@
         final ChangesetCache cache = ChangesetCache.getInstance();
         // empty cache => empty list
-        Assert.assertTrue(
+        assertTrue(
                 "Empty cache should produce an empty list.",
                 cache.getOpenChangesets().isEmpty()
+        );
+        assertTrue(
+                "Empty cache should produce an empty list.",
+                cache.getChangesets().isEmpty()
         );
 
@@ -199 +214 @@
         closedCs.setOpen(false);
         cache.update(closedCs);
-        Assert.assertTrue(
+        assertTrue(
                 "Cache with only closed changesets should produce an empty list.",
                 cache.getOpenChangesets().isEmpty()
         );
+        assertEquals(1, cache.getChangesets().size());
 
         // cache with open and closed changesets => list with only the open ones
@@ -208 +224 @@
         openCs.setOpen(true);
         cache.update(openCs);
-        Assert.assertEquals(
+        assertEquals(
                 Collections.singletonList(openCs),
                 cache.getOpenChangesets()
         );
+        assertEquals(2, cache.getChangesets().size());
+    }
+
+    /**
+     * Unit test of method {@link ChangesetCache#getOpenChangesetsForCurrentUser}.
+     */
+    @Test
+    public void testGetOpenChangesetsForCurrentUser() {
+        final ChangesetCache cache = ChangesetCache.getInstance();
+        // empty cache => empty list
+        assertTrue(
+                "Empty cache should produce an empty list.",
+                cache.getOpenChangesetsForCurrentUser().isEmpty()
+        );
+
+        Changeset openCs1 = new Changeset(1);
+        openCs1.setOpen(true);
+        openCs1.setUser(User.getAnonymous());
+        cache.update(openCs1);
+
+        Changeset openCs2 = new Changeset(2);
+        openCs2.setOpen(true);
+        openCs2.setUser(User.createLocalUser("foo"));
+        cache.update(openCs2);
+
+        Changeset closedCs = new Changeset(3);
+        closedCs.setOpen(false);
+        cache.update(closedCs);
+
+        assertEquals(3, cache.getChangesets().size());
+
+        JosmUserIdentityManager.getInstance().setAnonymous();
+        assertEquals(2, cache.getOpenChangesetsForCurrentUser().size());
+
+        JosmUserIdentityManager.getInstance().setPartiallyIdentified("foo");
+        assertEquals(1, cache.getOpenChangesetsForCurrentUser().size());
+    }
+
+    /**
+     * Unit test of methods {@link ChangesetCache#remove}.
+     */
+    @Test
+    public void testRemove() {
+        final ChangesetCache cache = ChangesetCache.getInstance();
+        Changeset cs1 = new Changeset(1);
+        cache.update(cs1);
+        assertEquals(1, cache.getChangesets().size());
+
+        cache.remove((Changeset) null);
+        cache.remove(cs1);
+        assertTrue(cache.getChangesets().isEmpty());
+
+        Changeset cs2 = new Changeset(2);
+        cache.update((Collection<Changeset>) null);
+        cache.update(Arrays.asList(cs1, cs2));
+        assertEquals(2, cache.getChangesets().size());
+
+        cache.remove((Collection<Changeset>) null);
+        cache.remove(Arrays.asList(cs1, cs2));
+        assertTrue(cache.getChangesets().isEmpty());
     }
 }