Changeset 11796 in josm for trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java

Timestamp:

2017-03-31T00:08:09+02:00 (7 years ago)

Author:

Don-vip

Message:

sonar - squid:S2259 - Null pointers should not be dereferenced

File:

• trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java

@@ -184 +184 @@
                 case SUCCESS:
                     handleNoTileAtZoom();
-                    int httpStatusCode = attributes.getResponseCode();
-                    if (httpStatusCode >= 400 && !isNoTileAtZoom()) {
-                        if (attributes.getErrorMessage() == null) {
-                            tile.setError(tr("HTTP error {0} when loading tiles", httpStatusCode));
-                        } else {
-                            tile.setError(tr("Error downloading tiles: {0}", attributes.getErrorMessage()));
+                    if (attributes != null) {
+                        int httpStatusCode = attributes.getResponseCode();
+                        if (httpStatusCode >= 400 && !isNoTileAtZoom()) {
+                            if (attributes.getErrorMessage() == null) {
+                                tile.setError(tr("HTTP error {0} when loading tiles", httpStatusCode));
+                            } else {
+                                tile.setError(tr("Error downloading tiles: {0}", attributes.getErrorMessage()));
+                            }
+                            status = false;
                         }
-                        status = false;
                     }
                     status &= tryLoadTileImage(object); //try to keep returned image as background