Changeset 11534 in josm for trunk/src/org/openstreetmap/josm/gui/io

Timestamp:

2017-02-04T14:47:39+01:00 (7 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:FCBL_FIELD_COULD_BE_LOCAL - Correctness - Class defines fields that are used only as locals

Location:

trunk/src/org/openstreetmap/josm/gui/io

Files:

• ActionFlagsTableCell.java (modified) (2 diffs)
• SaveLayersDialog.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/io/ActionFlagsTableCell.java

@@ -40 +40 @@
     private final transient CellEditorSupport cellEditorSupport = new CellEditorSupport(this);
 
-    private final transient ActionListener al = e -> cellEditorSupport.fireEditingStopped();
-
     /**
      * Constructs a new {@code ActionFlagsTableCell}.
@@ -50 +48 @@
         setLayout(new GridBagLayout());
 
+        ActionListener al = e -> cellEditorSupport.fireEditingStopped();
         ActionMap am = getActionMap();
         for (final JCheckBox b : checkBoxes) {

trunk/src/org/openstreetmap/josm/gui/io/SaveLayersDialog.java

@@ -527 +527 @@
         private final ExecutorService worker;
         private boolean canceled;
-        private Future<?> currentFuture;
         private AbstractIOTask currentTask;
 
@@ -565 +564 @@
                     continue;
                 }
-                currentFuture = worker.submit(currentTask);
+                Future<?> currentFuture = worker.submit(currentTask);
                 try {
                     // wait for the asynchronous task to complete
-                    //
                     currentFuture.get();
                 } catch (CancellationException e) {
@@ -606 +604 @@
                 }
                 currentTask = new SaveLayerTask(layerInfo, monitor);
-                currentFuture = worker.submit(currentTask);
+                Future<?> currentFuture = worker.submit(currentTask);
 
                 try {
@@ -632 +630 @@
                 }
                 this.currentTask = null;
-                this.currentFuture = null;
             }
         }