Changeset 11452 in josm for trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Check.java

Timestamp:

2017-01-12T01:24:40+01:00 (7 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:SEO_SUBOPTIMAL_EXPRESSION_ORDER - Performance - Method orders expressions in a conditional in a sub optimal way

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Check.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Check.java

@@ -92 +92 @@
     public void addCommands(List<Tag> changedTags) {
         // if the user hasn't changed anything, don't create a command.
-        if (check.getState() == initialState && def == null) return;
+        if (def == null && check.getState() == initialState) return;
 
         // otherwise change things according to the selected value.