Ignore:
Timestamp:
2017-01-12T01:24:40+01:00 (2 years ago)
Author:
Don-vip
Message:

sonar - fb-contrib:SEO_SUBOPTIMAL_EXPRESSION_ORDER - Performance - Method orders expressions in a conditional in a sub optimal way

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

    r11366 r11452  
    643643        Collection<String> history = Main.pref.getCollection(historyKey, def);
    644644        int age = (int) (System.currentTimeMillis() / 1000 - Main.pref.getInteger(BasicUploadSettingsPanel.HISTORY_LAST_USED_KEY, 0));
    645         if (age < Main.pref.getLong(BasicUploadSettingsPanel.HISTORY_MAX_AGE_KEY, TimeUnit.HOURS.toMillis(4))
    646                 && history != null && !history.isEmpty()) {
     645        if (history != null && age < Main.pref.getLong(BasicUploadSettingsPanel.HISTORY_MAX_AGE_KEY, TimeUnit.HOURS.toMillis(4))
     646                && !history.isEmpty()) {
    647647            return history.iterator().next();
    648648        } else {
Note: See TracChangeset for help on using the changeset viewer.