Changeset 11395 in josm for trunk/src/org/openstreetmap/josm/data/osm/Storage.java

Timestamp:

2016-12-14T04:45:14+01:00 (7 years ago)

Author:

Don-vip

Message:

refactor duplicated code

File:

• trunk/src/org/openstreetmap/josm/data/osm/Storage.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/osm/Storage.java

@@ -504 +504 @@
     }
 
-    private final class SafeReadonlyIter implements Iterator<T> {
-        private final T[] data;
-        private int slot;
-
-        SafeReadonlyIter(T[] data) {
-            this.data = data;
-        }
+    private abstract class AbstractIter implements Iterator<T> {
+        protected int slot;
 
         @Override
@@ -519 +514 @@
         }
 
+        protected void align() {
+            while (slot < data.length && data[slot] == null) {
+                slot++;
+            }
+        }
+    }
+
+    private final class SafeReadonlyIter extends AbstractIter {
+        private final T[] data;
+
+        SafeReadonlyIter(T[] data) {
+            this.data = data;
+        }
+
         @Override
         public T next() {
@@ -529 +538 @@
             throw new UnsupportedOperationException();
         }
-
-        private void align() {
-            while (slot < data.length && data[slot] == null) {
-                slot++;
-            }
-        }
-    }
-
-    private final class Iter implements Iterator<T> {
+    }
+
+    private final class Iter extends AbstractIter {
         private final int mods;
-        private int slot;
         private int removeSlot = -1;
 
         Iter() {
             mods = modCount;
-        }
-
-        @Override
-        public boolean hasNext() {
-            if (data == null) return false;
-            align();
-            return slot < data.length;
         }
 
@@ -569 +564 @@
         }
 
-        private void align() {
+        @Override
+        protected void align() {
             if (mods != modCount)
                 throw new ConcurrentModificationException();
-            while (slot < data.length && data[slot] == null) {
-                slot++;
-            }
-        }
-    }
-
+            super.align();
+        }
+    }
 }