Changeset 11394 in josm for trunk/src/org/openstreetmap/josm/tools

Timestamp:

2016-12-14T04:19:09+01:00 (4 years ago)

Author:

Don-vip

Message:

simplify preference settings equals handling (already performed by AbstractList.equals / AbstractMap.equals) - fixes squid:S1206 and findbugs HE_EQUALS_NO_HASHCODE warnings

File:

• trunk/src/org/openstreetmap/josm/tools/Utils.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/tools/Utils.java

@@ -42 +42 @@
 import java.util.List;
 import java.util.Locale;
-import java.util.Objects;
 import java.util.concurrent.Executor;
 import java.util.concurrent.ForkJoinPool;
@@ -524 +523 @@
     public static boolean equalsEpsilon(double a, double b) {
         return Math.abs(a - b) <= EPSILON;
-    }
-
-    /**
-     * Determines if two collections are equal.
-     * @param a first collection
-     * @param b second collection
-     * @return {@code true} if collections are equal, {@code false} otherwise
-     * @since 9217
-     */
-    public static boolean equalCollection(Collection<?> a, Collection<?> b) {
-        if (a == null) return b == null;
-        if (b == null) return false;
-        if (a.size() != b.size()) return false;
-        Iterator<?> itA = a.iterator();
-        Iterator<?> itB = b.iterator();
-        while (itA.hasNext()) {
-            if (!Objects.equals(itA.next(), itB.next()))
-                return false;
-        }
-        return true;
     }