Changeset 11394 in josm for trunk/src/org/openstreetmap/josm/data/preferences/StringSetting.java

Timestamp:

2016-12-14T04:19:09+01:00 (7 years ago)

Author:

Don-vip

Message:

simplify preference settings equals handling (already performed by AbstractList.equals / AbstractMap.equals) - fixes squid:S1206 and findbugs HE_EQUALS_NO_HASHCODE warnings

File:

• trunk/src/org/openstreetmap/josm/data/preferences/StringSetting.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/preferences/StringSetting.java

@@ -16 +16 @@
 
     @Override
-    public boolean equalVal(String otherVal) {
-        if (value == null)
-            return otherVal == null;
-        return value.equals(otherVal);
-    }
-
-    @Override
     public StringSetting copy() {
         return new StringSetting(value);
@@ -36 +29 @@
         return new StringSetting(null);
     }
-
-    @Override
-    public boolean equals(Object other) {
-        if (!(other instanceof StringSetting))
-            return false;
-        return equalVal(((StringSetting) other).getValue());
-    }
 }