Changeset 11394 in josm for trunk/src/org/openstreetmap/josm/data/preferences/Setting.java

Timestamp:

2016-12-14T04:19:09+01:00 (7 years ago)

Author:

Don-vip

Message:

simplify preference settings equals handling (already performed by AbstractList.equals / AbstractMap.equals) - fixes squid:S1206 and findbugs HE_EQUALS_NO_HASHCODE warnings

File:

• trunk/src/org/openstreetmap/josm/data/preferences/Setting.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/preferences/Setting.java

@@ -25 +25 @@
      * @return true if the values are equal
      */
-    boolean equalVal(T otherVal);
+    default boolean equalVal(T otherVal) {
+        return getValue() == null ? (otherVal == null) : getValue().equals(otherVal);
+    }
 
     /**