Changeset 11394 in josm for trunk/src/org/openstreetmap/josm/data/preferences/ListSetting.java

Timestamp:

2016-12-14T04:19:09+01:00 (7 years ago)

Author:

Don-vip

Message:

simplify preference settings equals handling (already performed by AbstractList.equals / AbstractMap.equals) - fixes squid:S1206 and findbugs HE_EQUALS_NO_HASHCODE warnings

File:

• trunk/src/org/openstreetmap/josm/data/preferences/ListSetting.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/preferences/ListSetting.java

@@ -6 +6 @@
 import java.util.Collections;
 import java.util.List;
-
-import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -33 +31 @@
 
     @Override
-    public boolean equalVal(List<String> otherVal) {
-        return Utils.equalCollection(value, otherVal);
-    }
-
-    @Override
     public ListSetting copy() {
         return ListSetting.create(value);
@@ -56 +49 @@
         return new ListSetting(null);
     }
-
-    @Override
-    public boolean equals(Object other) {
-        if (!(other instanceof ListSetting))
-            return false;
-        return equalVal(((ListSetting) other).getValue());
-    }
 }