Changeset 11383 in josm for trunk/test/unit/org/openstreetmap/josm/data

Timestamp:

2016-12-12T17:29:27+01:00 (7 years ago)

Author:

Don-vip

Message:

findbugs - BC_UNCONFIRMED_CAST

Location:

trunk/test/unit/org/openstreetmap/josm/data/osm

Files:

• NodeTest.java (modified) (1 diff)
• RelationTest.java (modified) (1 diff)
• WayTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/data/osm/NodeTest.java

@@ -80 +80 @@
         assertEquals(box1.getCenter(), new LatLon(15, 15));
     }
+
+    /**
+     * Test that {@link Node#cloneFrom} throws IAE for invalid arguments
+     */
+    @Test(expected = IllegalArgumentException.class)
+    public void testCloneFromIAE() {
+        new Node().cloneFrom(new Way());
+    }
+
+    /**
+     * Test that {@link Node#mergeFrom} throws IAE for invalid arguments
+     */
+    @Test(expected = IllegalArgumentException.class)
+    public void testMergeFromIAE() {
+        new Node().mergeFrom(new Way());
+    }
+
+    /**
+     * Test that {@link Node#load} throws IAE for invalid arguments
+     */
+    @Test(expected = IllegalArgumentException.class)
+    public void testLoadIAE() {
+        new Node().load(new WayData());
+    }
 }

trunk/test/unit/org/openstreetmap/josm/data/osm/RelationTest.java

@@ -139 +139 @@
         assertEquals(OsmPrimitiveType.RELATION, r.getDisplayType());
     }
+
+    /**
+     * Test that {@link Relation#cloneFrom} throws IAE for invalid arguments
+     */
+    @Test(expected = IllegalArgumentException.class)
+    public void testCloneFromIAE() {
+        new Relation().cloneFrom(new Node());
+    }
+
+    /**
+     * Test that {@link Relation#load} throws IAE for invalid arguments
+     */
+    @Test(expected = IllegalArgumentException.class)
+    public void testLoadIAE() {
+        new Relation().load(new NodeData());
+    }
 }

trunk/test/unit/org/openstreetmap/josm/data/osm/WayTest.java

@@ -55 +55 @@
         assertEquals(way.getBBox(), new BBox(10, 10));
     }
+
+    /**
+     * Test that {@link Way#cloneFrom} throws IAE for invalid arguments
+     */
+    @Test(expected = IllegalArgumentException.class)
+    public void testCloneFromIAE() {
+        new Way().cloneFrom(new Node());
+    }
+
+    /**
+     * Test that {@link Way#load} throws IAE for invalid arguments
+     */
+    @Test(expected = IllegalArgumentException.class)
+    public void testLoadIAE() {
+        new Way().load(new NodeData());
+    }
 }