Changeset 11381 in josm for trunk/src/org/openstreetmap/josm/data/cache/HostLimitQueue.java

Timestamp:

2016-12-12T02:28:14+01:00 (7 years ago)

Author:

Don-vip

Message:

findbugs - RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

File:

• trunk/src/org/openstreetmap/josm/data/cache/HostLimitQueue.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/cache/HostLimitQueue.java

@@ -89 +89 @@
         }
         job = takeFirst();
-        if (job != null) {
-            acquireSemaphore(job);
-        }
+        acquireSemaphore(job);
         return job;
     }
@@ -119 +117 @@
         if (job instanceof JCSCachedTileLoaderJob) {
             final JCSCachedTileLoaderJob<?, ?> jcsJob = (JCSCachedTileLoaderJob<?, ?>) job;
-            Semaphore limit = getSemaphore(jcsJob);
-            if (limit != null) {
-                limit.acquire();
-                jcsJob.setFinishedTask(() -> releaseSemaphore(jcsJob));
-            }
+            getSemaphore(jcsJob).acquire();
+            jcsJob.setFinishedTask(() -> releaseSemaphore(jcsJob));
         }
     }