Changeset 11374 in josm for trunk/src/org/openstreetmap/josm/command

Timestamp:

2016-12-09T23:31:13+01:00 (4 years ago)

Author:

Don-vip

Message:

sonar - squid:S00112 - Generic exceptions should never be thrown: define JosmRuntimeException

File:

• trunk/src/org/openstreetmap/josm/command/AddPrimitivesCommand.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/command/AddPrimitivesCommand.java

@@ -19 +19 @@
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.tools.CheckParameterUtil;
+import org.openstreetmap.josm.tools.JosmRuntimeException;
 
 /**
@@ -170 +171 @@
             OsmPrimitive osm = getAffectedDataSet().getPrimitiveById(d);
             if (osm == null)
-                throw new RuntimeException();
+                throw new JosmRuntimeException("No primitive found for " + d);
             prims.add(osm);
         }
@@ -188 +189 @@
         AddPrimitivesCommand that = (AddPrimitivesCommand) obj;
         return Objects.equals(data, that.data) &&
-                Objects.equals(toSelect, that.toSelect) &&
-                Objects.equals(createdPrimitives, that.createdPrimitives) &&
-                Objects.equals(createdPrimitivesToSelect, that.createdPrimitivesToSelect);
+               Objects.equals(toSelect, that.toSelect) &&
+               Objects.equals(createdPrimitives, that.createdPrimitives) &&
+               Objects.equals(createdPrimitivesToSelect, that.createdPrimitivesToSelect);
     }
 }