Changeset 11368 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2016-12-08T01:47:27+01:00 (7 years ago)

Author:

Don-vip

Message:

see #14043 - review use of short type

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/AbstractPrimitive.java (modified) (4 diffs)
• data/osm/OsmPrimitive.java (modified) (2 diffs)
• gui/mappaint/ElemStyles.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -57 +57 @@
      * and on upload the object will be send to the server.
      */
-    protected static final short FLAG_MODIFIED = 1 << 0;
+    protected static final short FLAG_MODIFIED = 0x0001;
 
     /**
@@ -63 +63 @@
      * as deleted on the server.
      */
-    protected static final short FLAG_VISIBLE = 1 << 1;
+    protected static final short FLAG_VISIBLE = 0x0010;
 
     /**
@@ -72 +72 @@
      * objects still referring to it.
      */
-    protected static final short FLAG_DELETED = 1 << 2;
+    protected static final short FLAG_DELETED = 0x0100;
 
     /**
@@ -79 +79 @@
      * fetched from the server.
      */
-    protected static final short FLAG_INCOMPLETE = 1 << 3;
+    protected static final short FLAG_INCOMPLETE = 0x1000;
 
     /**

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java

@@ -248 +248 @@
      *--------*/
     public StyleCache mappaintStyle;
-    public int mappaintCacheIdx;
+    private short mappaintCacheIdx;
 
     /* This should not be called from outside. Fixing the UI to add relevant
@@ -256 +256 @@
         mappaintStyle = null;
     }
+
+    /**
+     * Returns mappaint cache index.
+     * @return mappaint cache index
+     */
+    public final short getMappaintCacheIdx() {
+        return mappaintCacheIdx;
+    }
+
+    /**
+     * Sets the mappaint cache index.
+     * @param mappaintCacheIdx mappaint cache index
+     */
+    public final void setMappaintCacheIdx(short mappaintCacheIdx) {
+        this.mappaintCacheIdx = mappaintCacheIdx;
+    }
+
     /* end of mappaint data */
 

trunk/src/org/openstreetmap/josm/gui/mappaint/ElemStyles.java

@@ -52 +52 @@
  * The results are cached with respect to the current scale.
  *
- * Use {@link #setStyleSources(Collection)} to select the StyleSources that are
- * applied.
+ * Use {@link #setStyleSources(Collection)} to select the StyleSources that are applied.
  */
 public class ElemStyles implements PreferenceChangedListener {
@@ -59 +58 @@
     private boolean drawMultipolygon;
 
-    private int cacheIdx = 1;
-
-    private boolean defaultNodes, defaultLines;
-    private int defaultNodesIdx, defaultLinesIdx;
+    private short cacheIdx = 1;
+
+    private boolean defaultNodes;
+    private boolean defaultLines;
+
+    private short defaultNodesIdx;
+    private short defaultLinesIdx;
 
     private final Map<String, String> preferenceCache = new HashMap<>();
@@ -112 +114 @@
      */
     public Pair<StyleElementList, Range> getStyleCacheWithRange(OsmPrimitive osm, double scale, NavigatableComponent nc) {
-        if (osm.mappaintStyle == null || osm.mappaintCacheIdx != cacheIdx || scale <= 0) {
+        if (osm.mappaintStyle == null || osm.getMappaintCacheIdx() != cacheIdx || scale <= 0) {
             osm.mappaintStyle = StyleCache.EMPTY_STYLECACHE;
         } else {
@@ -170 +172 @@
                     + ", scale: " + scale + ", new stylelist: " + p.a + ", new range: " + p.b + ')', e);
         }
-        osm.mappaintCacheIdx = cacheIdx;
+        osm.setMappaintCacheIdx(cacheIdx);
         return p;
     }