Changeset 11357 in josm for trunk/src/org/openstreetmap/josm/command

Timestamp:

2016-12-03T18:16:10+01:00 (7 years ago)

Author:

Don-vip

Message:

findbugs - SIC_INNER_SHOULD_BE_STATIC_ANON

File:

• trunk/src/org/openstreetmap/josm/command/ChangePropertyKeyCommand.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/command/ChangePropertyKeyCommand.java

@@ -20 +20 @@
 /**
  * Command that replaces the key of one or several objects
- *
+ * @since 3669
  */
 public class ChangePropertyKeyCommand extends Command {
+    final class SinglePrimitivePseudoCommand implements PseudoCommand {
+        private final String name;
+        private final OsmPrimitive osm;
+        private final Icon icon;
+
+        SinglePrimitivePseudoCommand(String name, OsmPrimitive osm, Icon icon) {
+            this.name = name;
+            this.osm = osm;
+            this.icon = icon;
+        }
+
+        @Override
+        public String getDescriptionText() {
+            return name;
+        }
+
+        @Override
+        public Icon getDescriptionIcon() {
+            return icon;
+        }
+
+        @Override
+        public Collection<? extends OsmPrimitive> getParticipatingPrimitives() {
+            return Collections.singleton(osm);
+        }
+    }
+
     /**
      * All primitives, that are affected with this command.
@@ -108 +135 @@
         for (final OsmPrimitive osm : objects) {
             osm.accept(v);
-            final String name = v.name;
-            final Icon icon = v.icon;
-            children.add(new PseudoCommand() {
-                @Override
-                public String getDescriptionText() {
-                    return name;
-                }
-
-                @Override
-                public Icon getDescriptionIcon() {
-                    return icon;
-                }
-
-                @Override
-                public Collection<? extends OsmPrimitive> getParticipatingPrimitives() {
-                    return Collections.singleton(osm);
-                }
-            });
+            children.add(new SinglePrimitivePseudoCommand(v.name, osm, v.icon));
         }
         return children;