Changeset 11348 in josm for trunk/src/org/openstreetmap/josm/command/ChangePropertyCommand.java

Timestamp:

2016-11-30T01:38:40+01:00 (7 years ago)

Author:

Don-vip

Message:

findbugs - fix some SIC_INNER_SHOULD_BE_STATIC_ANON

File:

• trunk/src/org/openstreetmap/josm/command/ChangePropertyCommand.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/command/ChangePropertyCommand.java

@@ -6 +6 @@
 import static org.openstreetmap.josm.tools.I18n.trn;
 
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
@@ -15 +14 @@
 import java.util.Map;
 import java.util.Objects;
+import java.util.stream.Collectors;
 
 import javax.swing.Icon;
@@ -33 +33 @@
  */
 public class ChangePropertyCommand extends Command {
+
+    static final class OsmPseudoCommand implements PseudoCommand {
+        private final OsmPrimitive osm;
+
+        OsmPseudoCommand(OsmPrimitive osm) {
+            this.osm = osm;
+        }
+
+        @Override
+        public String getDescriptionText() {
+            return osm.getDisplayName(DefaultNameFormatter.getInstance());
+        }
+
+        @Override
+        public Icon getDescriptionIcon() {
+            return ImageProvider.get(osm.getDisplayType());
+        }
+
+        @Override
+        public Collection<? extends OsmPrimitive> getParticipatingPrimitives() {
+            return Collections.singleton(osm);
+        }
+    }
+
     /**
      * All primitives that are affected with this command.
@@ -212 +236 @@
         if (objects.size() == 1)
             return null;
-        List<PseudoCommand> children = new ArrayList<>();
-        for (final OsmPrimitive osm : objects) {
-            children.add(new PseudoCommand() {
-                @Override public String getDescriptionText() {
-                    return osm.getDisplayName(DefaultNameFormatter.getInstance());
-                }
-
-                @Override public Icon getDescriptionIcon() {
-                    return ImageProvider.get(osm.getDisplayType());
-                }
-
-                @Override public Collection<? extends OsmPrimitive> getParticipatingPrimitives() {
-                    return Collections.singleton(osm);
-                }
-            });
-        }
-        return children;
+        return objects.stream().map(OsmPseudoCommand::new).collect(Collectors.toList());
     }