Changeset 10939 in josm for trunk/src/org/openstreetmap/josm/tools

Timestamp:

2016-09-03T12:42:28+02:00 (3 years ago)

Author:

Don-vip

Message:

sonar - pmd:ImmutableField - Immutable Field

Location:

trunk/src/org/openstreetmap/josm/tools

Files:

• ListenerList.java (modified) (3 diffs)
• bugreport/BugReportQueue.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/tools/ListenerList.java

@@ -35 +35 @@
     private static final class WeakListener<T> {
 
-        private WeakReference<T> listener;
+        private final WeakReference<T> listener;
 
         WeakListener(T listener) {
@@ -62 +62 @@
         @Override
         public String toString() {
-            return "WeakListener [listener=" + listener + "]";
+            return "WeakListener [listener=" + listener + ']';
         }
     }
@@ -165 +165 @@
      */
     public static class TracingListenerList<T> extends ListenerList<T> {
-        private HashMap<T, StackTraceElement[]> listenersAdded = new HashMap<>();
-        private HashMap<T, StackTraceElement[]> listenersRemoved = new HashMap<>();
+        private final HashMap<T, StackTraceElement[]> listenersAdded = new HashMap<>();
+        private final HashMap<T, StackTraceElement[]> listenersRemoved = new HashMap<>();
 
         protected TracingListenerList() {

trunk/src/org/openstreetmap/josm/tools/bugreport/BugReportQueue.java

@@ -20 +20 @@
     private static final BugReportQueue INSTANCE = new BugReportQueue();
 
-    private LinkedList<ReportedException> reportsToDisplay = new LinkedList<>();
+    private final LinkedList<ReportedException> reportsToDisplay = new LinkedList<>();
     private boolean suppressAllMessages;
-    private ArrayList<ReportedException> suppressFor = new ArrayList<>();
+    private final ArrayList<ReportedException> suppressFor = new ArrayList<>();
     private Thread displayThread;
     private final BiFunction<ReportedException, Integer, SuppressionMode> bugReportHandler = getBestHandler();