Changeset 10937 in josm for trunk/test/unit/org/openstreetmap/josm/actions/mapmode/SelectActionTest.java

Timestamp:

2016-09-03T12:24:18+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S3658 - Unit tests should throw exceptions

File:

• trunk/test/unit/org/openstreetmap/josm/actions/mapmode/SelectActionTest.java (modified) (3 diffs)

trunk/test/unit/org/openstreetmap/josm/actions/mapmode/SelectActionTest.java

@@ -5 +5 @@
 import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
 
 import java.awt.event.InputEvent;
@@ -35 +34 @@
 
     class SelectActionMock extends SelectAction {
-        SelectActionMock(MapFrame mapFrame, DataSet dataSet, OsmDataLayer layer) {
+        SelectActionMock(MapFrame mapFrame, DataSet dataSet, OsmDataLayer layer) throws ReflectiveOperationException {
             super(mapFrame);
-            try {
-                Field mv = SelectAction.class.getDeclaredField("mv");
-                Utils.setObjectsAccessible(mv);
-                mv.set(this, new MapViewMock());
-            } catch (ReflectiveOperationException e) {
-                e.printStackTrace();
-                fail("Can't setup testing environnement");
-            }
+            Field mv = SelectAction.class.getDeclaredField("mv");
+            Utils.setObjectsAccessible(mv);
+            mv.set(this, new MapViewMock());
         }
 
@@ -68 +62 @@
      * Resulting way should be attach to the third node.
      * see #10748
+     * @throws ReflectiveOperationException if an error occurs
      */
     @Test
     @SuppressFBWarnings(value = "ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD")
-    public void testTicket10748() {
+    public void testTicket10748() throws ReflectiveOperationException {
         DataSet dataSet = new DataSet();
         OsmDataLayer layer = new OsmDataLayer(dataSet, OsmDataLayer.createNewName(), null);