Changeset 10632 in josm for trunk/src/org/openstreetmap/josm/data/osm

Timestamp:

2016-07-24T23:50:15+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:RedundantThrowsDeclarationCheck - Throws declarations should not be superfluous

Location:

trunk/src/org/openstreetmap/josm/data/osm

Files:

• MultipolygonBuilder.java (modified) (1 diff)
• Relation.java (modified) (2 diffs)
• Way.java (modified) (1 diff)
• history/HistoryRelation.java (modified) (1 diff)
• history/HistoryWay.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/MultipolygonBuilder.java

@@ -170 +170 @@
      * @throws JoinedPolygonCreationException if the creation fails.
      */
-    public static List<JoinedPolygon> joinWays(Collection<Way> ways) throws JoinedPolygonCreationException {
+    public static List<JoinedPolygon> joinWays(Collection<Way> ways) {
         List<JoinedPolygon> joinedWays = new ArrayList<>();
 

trunk/src/org/openstreetmap/josm/data/osm/Relation.java

@@ -484 +484 @@
     }
 
-    private void checkMembers() throws DataIntegrityProblemException {
+    /**
+     * Checks that members are part of the same dataset, and that they're not deleted.
+     * @throws DataIntegrityProblemException if one the above conditions is not met
+     */
+    private void checkMembers() {
         DataSet dataSet = getDataSet();
         if (dataSet != null) {
@@ -503 +507 @@
     }
 
-    private void fireMembersChanged() throws DataIntegrityProblemException {
+    /**
+     * Fires the {@code RelationMembersChangedEvent} to listeners.
+     * @throws DataIntegrityProblemException if members are not valid
+     * @see #checkMembers
+     */
+    private void fireMembersChanged() {
         checkMembers();
         if (getDataSet() != null) {

trunk/src/org/openstreetmap/josm/data/osm/Way.java

@@ -448 +448 @@
      * @since 1313
      */
-    public void addNode(int offs, Node n) throws IndexOutOfBoundsException {
+    public void addNode(int offs, Node n) {
         if (n == null) return;
 

trunk/src/org/openstreetmap/josm/data/osm/history/HistoryRelation.java

@@ -111 +111 @@
      * @throws IndexOutOfBoundsException if idx is out of bounds
      */
-    public RelationMemberData getRelationMember(int idx) throws IndexOutOfBoundsException {
+    public RelationMemberData getRelationMember(int idx) {
         if (idx < 0 || idx >= members.size())
             throw new IndexOutOfBoundsException(

trunk/src/org/openstreetmap/josm/data/osm/history/HistoryWay.java

@@ -97 +97 @@
      * @throws IndexOutOfBoundsException if  idx < 0 || idx >= {#see {@link #getNumNodes()}
      */
-    public long getNodeId(int idx) throws IndexOutOfBoundsException {
+    public long getNodeId(int idx) {
         if (idx < 0 || idx >= nodeIds.size())
             throw new IndexOutOfBoundsException(tr("Parameter {0} not in range 0..{1}. Got ''{2}''.", "idx", nodeIds.size(), idx));