Changeset 10300 in josm for trunk/src/org/openstreetmap/josm/io

Timestamp:

2016-05-30T01:17:28+02:00 (10 years ago)

Author:

Don-vip

Message:

sonar - Performance - Method passes constant String of length 1 to character overridden method + add unit tests/javadoc

Location:

trunk/src/org/openstreetmap/josm/io

Files:

• ChangesetQuery.java (modified) (1 diff)
• MultiFetchOverpassObjectReader.java (modified) (2 diffs)
• remotecontrol/handler/VersionHandler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/ChangesetQuery.java

@@ -241 +241 @@
         CheckParameterUtil.ensureParameterNotNull(changesetIds, "changesetIds");
         if (changesetIds.size() > MAX_CHANGESETS_NUMBER) {
-            Main.warn("Changeset query built with more than " + MAX_CHANGESETS_NUMBER + " changeset ids (" + changesetIds.size() + ")");
+            Main.warn("Changeset query built with more than " + MAX_CHANGESETS_NUMBER + " changeset ids (" + changesetIds.size() + ')');
         }
         this.changesetIds = changesetIds;

trunk/src/org/openstreetmap/josm/io/MultiFetchOverpassObjectReader.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.io;
+
+import java.util.Set;
 
 import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
 import org.openstreetmap.josm.gui.preferences.server.OverpassServerPreference;
 import org.openstreetmap.josm.tools.Utils;
-
-import java.util.Set;
 
 /**
@@ -20 +20 @@
             @Override
             public Object apply(Long x) {
-                return type.getAPIName() + "(" + x + ");>;";
+                return type.getAPIName() + '(' + x + ");>;";
             }
         };
-        final String query = "(" + Utils.join("", Utils.transform(idPackage, toOverpassExpression)) + ");out meta;";
+        final String query = '(' + Utils.join("", Utils.transform(idPackage, toOverpassExpression)) + ");out meta;";
         return "interpreter?data=" + Utils.encodeUrl(query);
     }

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/VersionHandler.java

@@ -23 +23 @@
         contentType = "application/json";
         if (args.containsKey("jsonp")) {
-            content = args.get("jsonp") + " && " + args.get("jsonp") + "(" + content + ')';
+            content = args.get("jsonp") + " && " + args.get("jsonp") + '(' + content + ')';
         }
     }