Changeset 10300 in josm for trunk/src/org/openstreetmap/josm/gui/tagging/presets

Timestamp:

2016-05-30T01:17:28+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - Performance - Method passes constant String of length 1 to character overridden method + add unit tests/javadoc

Location:

trunk/src/org/openstreetmap/josm/gui/tagging/presets

Files:

• TaggingPreset.java (modified) (1 diff)
• TaggingPresetSelector.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPreset.java

@@ -530 +530 @@
     @Override
     public String toString() {
-        return (types == null ? "" : types) + " " + name;
+        return (types == null ? "" : types.toString()) + ' ' + name;
     }
 

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java

@@ -168 +168 @@
         @Override
         public String toString() {
-            return classification + " " + preset;
+            return Integer.toString(classification) + ' ' + preset;
         }
     }