Index: trunk/src/org/openstreetmap/josm/actions/OpenFileAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/OpenFileAction.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/actions/OpenFileAction.java (revision 10242) @@ -183,12 +183,10 @@ protected void alertFilesNotMatchingWithImporter(Collection files, FileImporter importer) { - final StringBuilder msg = new StringBuilder(); - msg.append("").append( - trn( - "Cannot open {0} file with the file importer ''{1}''.", - "Cannot open {0} files with the file importer ''{1}''.", - files.size(), - files.size(), - importer.filter.getDescription() + final StringBuilder msg = new StringBuilder(128).append("").append( + trn("Cannot open {0} file with the file importer ''{1}''.", + "Cannot open {0} files with the file importer ''{1}''.", + files.size(), + files.size(), + importer.filter.getDescription() ) ).append("
"); + msg.append(""); HelpAwareOptionPane.showMessageDialogInEDT( @@ -208,11 +206,9 @@ protected void alertFilesWithUnknownImporter(Collection files) { - final StringBuilder msg = new StringBuilder(); - msg.append("").append( - trn( - "Cannot open {0} file because file does not exist or no suitable file importer is available.", - "Cannot open {0} files because files do not exist or no suitable file importer is available.", - files.size(), - files.size() + final StringBuilder msg = new StringBuilder(128).append("").append( + trn("Cannot open {0} file because file does not exist or no suitable file importer is available.", + "Cannot open {0} files because files do not exist or no suitable file importer is available.", + files.size(), + files.size() ) ).append("
"); + msg.append(""); HelpAwareOptionPane.showMessageDialogInEDT( @@ -272,6 +268,5 @@ } }); - // TODO when changing to Java 6: Don't cancel the - // task here but use different modality. (Currently 2 dialogs + // TODO when changing to Java 6: Don't cancel the task here but use different modality. (Currently 2 dialogs // would block each other.) return; Index: trunk/src/org/openstreetmap/josm/actions/SearchNotesDownloadAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/SearchNotesDownloadAction.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/actions/SearchNotesDownloadAction.java (revision 10242) @@ -75,10 +75,14 @@ } + /** + * Perform search. + * @param searchTerm search term + */ public void performSearch(String searchTerm) { - searchTerm = searchTerm.trim(); + String trimmedSearchTerm = searchTerm.trim(); try { - final long id = Long.parseLong(searchTerm); + final long id = Long.parseLong(trimmedSearchTerm); new DownloadNotesTask().download(id, null); return; @@ -92,5 +96,5 @@ int closedLimit = Main.pref.getInteger("osm.notes.daysCloased", 7); - StringBuilder sb = new StringBuilder(); + StringBuilder sb = new StringBuilder(128); sb.append(OsmApi.getOsmApi().getBaseUrl()) .append("notes/search?limit=") @@ -99,5 +103,5 @@ .append(closedLimit) .append("&q=") - .append(Utils.encodeUrl(searchTerm)); + .append(Utils.encodeUrl(trimmedSearchTerm)); new DownloadNotesTask().loadUrl(false, sb.toString(), null); Index: trunk/src/org/openstreetmap/josm/actions/ShowStatusReportAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/ShowStatusReportAction.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/actions/ShowStatusReportAction.java (revision 10242) @@ -78,5 +78,5 @@ */ public static String getReportHeader() { - StringBuilder text = new StringBuilder(); + StringBuilder text = new StringBuilder(256); String runtimeVersion = System.getProperty("java.runtime.version"); text.append(Version.getInstance().getReleaseAttributes()) Index: trunk/src/org/openstreetmap/josm/actions/downloadtasks/AbstractDownloadTask.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/downloadtasks/AbstractDownloadTask.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/actions/downloadtasks/AbstractDownloadTask.java (revision 10242) @@ -84,5 +84,5 @@ @Override public String acceptsDocumentationSummary() { - StringBuilder buff = new StringBuilder(""); + StringBuilder buff = new StringBuilder(128).append(""); buff.append(getTitle()) .append(":"); Index: trunk/src/org/openstreetmap/josm/data/osm/Relation.java =================================================================== --- trunk/src/org/openstreetmap/josm/data/osm/Relation.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/data/osm/Relation.java (revision 10242) @@ -267,5 +267,5 @@ @Override public String toString() { - StringBuilder result = new StringBuilder(); + StringBuilder result = new StringBuilder(32); result.append("{Relation id=") .append(getUniqueId()) Index: trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2GridShiftFile.java =================================================================== --- trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2GridShiftFile.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2GridShiftFile.java (revision 10242) @@ -271,5 +271,5 @@ @Override public String toString() { - StringBuilder buff = new StringBuilder("Headers : "); + StringBuilder buff = new StringBuilder(256).append("Headers : "); buff.append(overviewHeaderCount) .append("\nSub Hdrs : ") Index: trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2SubGrid.java =================================================================== --- trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2SubGrid.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2SubGrid.java (revision 10242) @@ -295,5 +295,5 @@ */ public String getDetails() { - StringBuilder buff = new StringBuilder("Sub Grid : "); + StringBuilder buff = new StringBuilder(256).append("Sub Grid : "); buff.append(subGridName) .append("\nParent : ") Index: trunk/src/org/openstreetmap/josm/data/validation/routines/RegexValidator.java =================================================================== --- trunk/src/org/openstreetmap/josm/data/validation/routines/RegexValidator.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/data/validation/routines/RegexValidator.java (revision 10242) @@ -219,5 +219,5 @@ @Override public String toString() { - StringBuilder buffer = new StringBuilder(); + StringBuilder buffer = new StringBuilder(32); buffer.append("RegexValidator{"); for (int i = 0; i < patterns.length; i++) { Index: trunk/src/org/openstreetmap/josm/gui/DefaultNameFormatter.java =================================================================== --- trunk/src/org/openstreetmap/josm/gui/DefaultNameFormatter.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/gui/DefaultNameFormatter.java (revision 10242) @@ -481,5 +481,5 @@ private static String buildDefaultToolTip(long id, Map tags) { - StringBuilder sb = new StringBuilder(); + StringBuilder sb = new StringBuilder(128); sb.append("id=") .append(id) Index: trunk/src/org/openstreetmap/josm/gui/io/ChangesetCellRenderer.java =================================================================== --- trunk/src/org/openstreetmap/josm/gui/io/ChangesetCellRenderer.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/gui/io/ChangesetCellRenderer.java (revision 10242) @@ -34,5 +34,5 @@ protected String buildToolTipText(Changeset cs) { - StringBuilder sb = new StringBuilder(); + StringBuilder sb = new StringBuilder(64); sb.append("").append(tr("Changeset id:")).append("").append(cs.getId()).append("
"); if (cs.getCreatedAt() != null) { Index: trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/NodeElement.java =================================================================== --- trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/NodeElement.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/NodeElement.java (revision 10242) @@ -379,7 +379,6 @@ @Override - public String toString() { - StringBuilder s = new StringBuilder("NodeElemStyle{"); + StringBuilder s = new StringBuilder(64).append("NodeElemStyle{"); s.append(super.toString()); if (mapImage != null) { Index: trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java =================================================================== --- trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java (revision 10242) @@ -1514,5 +1514,5 @@ if (entry == null) return null; - StringBuilder s = new StringBuilder(""); + StringBuilder s = new StringBuilder(128).append(""); if (entry.title != null) { s.append(entry.title).append(" "); Index: trunk/src/org/openstreetmap/josm/gui/preferences/projection/CustomProjectionChoice.java =================================================================== --- trunk/src/org/openstreetmap/josm/gui/preferences/projection/CustomProjectionChoice.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/gui/preferences/projection/CustomProjectionChoice.java (revision 10242) @@ -164,5 +164,5 @@ private static JComponent build() { - StringBuilder s = new StringBuilder(); + StringBuilder s = new StringBuilder(1024); s.append("+proj=... - ").append(tr("Projection name")) .append("
    ").append(tr("Supported values:")).append(' ') Index: trunk/src/org/openstreetmap/josm/io/OsmServerChangesetReader.java =================================================================== --- trunk/src/org/openstreetmap/josm/io/OsmServerChangesetReader.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/io/OsmServerChangesetReader.java (revision 10242) @@ -45,6 +45,5 @@ protected final InputStream getChangesetInputStream(long id, boolean includeDiscussion, ProgressMonitor monitor) throws OsmTransferException { - StringBuilder sb = new StringBuilder(); - sb.append("changeset/").append(id); + StringBuilder sb = new StringBuilder(48).append("changeset/").append(id); if (includeDiscussion) { sb.append("?include_discussion=true"); @@ -201,6 +200,5 @@ try { monitor.beginTask(tr("Downloading changeset content")); - StringBuilder sb = new StringBuilder(); - sb.append("changeset/").append(id).append("/download"); + StringBuilder sb = new StringBuilder(32).append("changeset/").append(id).append("/download"); try (InputStream in = getInputStream(sb.toString(), monitor.createSubTaskMonitor(1, true))) { if (in == null) Index: trunk/src/org/openstreetmap/josm/io/remotecontrol/AddTagsDialog.java =================================================================== --- trunk/src/org/openstreetmap/josm/io/remotecontrol/AddTagsDialog.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/io/remotecontrol/AddTagsDialog.java (revision 10242) @@ -99,5 +99,5 @@ private String getToolTip() { - StringBuilder sb = new StringBuilder(); + StringBuilder sb = new StringBuilder(64); sb.append("") .append(tr("Old values of")) Index: trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java =================================================================== --- trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (revision 10242) @@ -919,5 +919,5 @@ private static void alertFailedPluginUpdate(Component parent, Collection plugins) { - StringBuilder sb = new StringBuilder(); + StringBuilder sb = new StringBuilder(128); sb.append("") .append(trn( @@ -1296,5 +1296,5 @@ }; - final StringBuilder msg = new StringBuilder(); + final StringBuilder msg = new StringBuilder(256); msg.append("") .append(tr("An unexpected exception occurred that may have come from the ''{0}'' plugin.", plugin.getPluginInformation().name)) Index: trunk/src/org/openstreetmap/josm/tools/PlatformHookOsx.java =================================================================== --- trunk/src/org/openstreetmap/josm/tools/PlatformHookOsx.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/tools/PlatformHookOsx.java (revision 10242) @@ -323,5 +323,5 @@ canHtml = false; } - StringBuilder result = new StringBuilder(); + StringBuilder result = new StringBuilder(48); if (canHtml) { result.append(""); Index: trunk/src/org/openstreetmap/josm/tools/WindowGeometry.java =================================================================== --- trunk/src/org/openstreetmap/josm/tools/WindowGeometry.java (revision 10241) +++ trunk/src/org/openstreetmap/josm/tools/WindowGeometry.java (revision 10242) @@ -262,5 +262,5 @@ */ public void remember(String preferenceKey) { - StringBuilder value = new StringBuilder(); + StringBuilder value = new StringBuilder(32); value.append("x=").append(topLeft.x).append(",y=").append(topLeft.y) .append(",width=").append(extent.width).append(",height=").append(extent.height);