Changeset 10238 in josm for trunk/src/org/openstreetmap/josm/plugins

Timestamp:

2016-05-17T02:32:56+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S1873 - "static final" arrays should be "private"

File:

• trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -220 +220 @@
      * List of unmaintained plugins. Not really up-to-date as the vast majority of plugins are not maintained after a few months, sadly...
      */
-    static final String[] UNMAINTAINED_PLUGINS = new String[] {
+    static final List<String> UNMAINTAINED_PLUGINS = Collections.unmodifiableList(Arrays.asList(
         "gpsbabelgui",
         "Intersect_way",
@@ -226 +226 @@
         "LaneConnector",           // See #11468, #11518, https://github.com/TrifanAdrian/LanecConnectorPlugin/issues/1
         "Remove.redundant.points"  // See #11468, #11518, https://github.com/bularcasergiu/RemoveRedundantPoints (not even created an issue...)
-    };
+    ));
 
     /**
@@ -1486 +1486 @@
      */
     public static Set<String> getDeprecatedAndUnmaintainedPlugins() {
-        Set<String> result = new HashSet<>(DEPRECATED_PLUGINS.size() + UNMAINTAINED_PLUGINS.length);
+        Set<String> result = new HashSet<>(DEPRECATED_PLUGINS.size() + UNMAINTAINED_PLUGINS.size());
         for (DeprecatedPlugin dp : DEPRECATED_PLUGINS) {
             result.add(dp.name);
         }
-        result.addAll(Arrays.asList(UNMAINTAINED_PLUGINS));
+        result.addAll(UNMAINTAINED_PLUGINS);
         return result;
     }