Changeset 10222 in josm for trunk/test/unit/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJobTest.java

Timestamp:

2016-05-15T21:14:06+02:00 (8 years ago)

Author:

Don-vip

Message:

findbugs - fix/suppress most of warnings reported in unit tests + enable low confidence warnings for core

File:

• trunk/test/unit/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJobTest.java (modified) (5 diffs)

trunk/test/unit/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJobTest.java

@@ -13 +13 @@
 import org.junit.Test;
 import org.openstreetmap.josm.JOSMFixture;
+
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 /**
@@ -59 +61 @@
             this.attributes = attributes;
             this.ready = true;
-            this.notify();
+            this.notifyAll();
         }
     }
@@ -71 +73 @@
     }
 
+    /**
+     * Test status codes
+     * @throws InterruptedException in case of thread interruption
+     * @throws IOException in case of I/O error
+     */
     @Test
-    public void testStatusCodes() throws Exception {
+    public void testStatusCodes() throws IOException, InterruptedException  {
         doTestStatusCode(200);
         // can't test for 3xx, as httpstat.us redirects finally to 200 page
@@ -85 +92 @@
     }
 
+    /**
+     * Test unknown host
+     * @throws InterruptedException in case of thread interruption
+     * @throws IOException in case of I/O error
+     */
     @Test
-    public void testUnknownHost() throws Exception {
+    @SuppressFBWarnings(value = "WA_NOT_IN_LOOP")
+    public void testUnknownHost() throws IOException, InterruptedException {
         TestCachedTileLoaderJob job = new TestCachedTileLoaderJob("http://unkownhost.unkownhost/unkown");
         Listener listener = new Listener();
@@ -98 +111 @@
     }
 
-    private void doTestStatusCode(int responseCode) throws Exception {
+    @SuppressFBWarnings(value = "WA_NOT_IN_LOOP")
+    private void doTestStatusCode(int responseCode) throws IOException, InterruptedException {
         TestCachedTileLoaderJob job = getStatusLoaderJob(responseCode);
         Listener listener = new Listener();