Changeset 10222 in josm for trunk/test/unit/org/openstreetmap/josm/actions/CreateCircleActionTest.java

Timestamp:

2016-05-15T21:14:06+02:00 (8 years ago)

Author:

Don-vip

Message:

findbugs - fix/suppress most of warnings reported in unit tests + enable low confidence warnings for core

File:

• trunk/test/unit/org/openstreetmap/josm/actions/CreateCircleActionTest.java (modified) (3 diffs)

trunk/test/unit/org/openstreetmap/josm/actions/CreateCircleActionTest.java

@@ -9 +9 @@
 import java.lang.reflect.Field;
 import java.lang.reflect.Method;
+import java.security.AccessController;
+import java.security.PrivilegedAction;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -56 +58 @@
     public void addSelected(OsmPrimitive p, DataSet ds) {
         try {
-            Method method = ds.getClass()
+            final Method method = ds.getClass()
                 .getDeclaredMethod("addSelected",
                                    new Class<?>[] {Collection.class, boolean.class});
-            method.setAccessible(true);
+            AccessController.doPrivileged(new PrivilegedAction<Object>() {
+                @Override
+                public Object run() {
+                    method.setAccessible(true);
+                    return null;
+                }
+            });
             method.invoke(ds, Collections.singleton(p), false);
-        } catch (Exception e) {
+        } catch (ReflectiveOperationException e) {
             e.printStackTrace();
             fail("Can't add OsmPrimitive to dataset: " + e.getMessage());
@@ -162 +170 @@
             rlCache.setAccessible(true);
             ConstantTrafficHand trafficHand = new ConstantTrafficHand(true);
-            rlCache.set(null, new GeoPropertyIndex<Boolean>(trafficHand, 24));
-        } catch (Exception e) {
+            rlCache.set(null, new GeoPropertyIndex<>(trafficHand, 24));
+        } catch (ReflectiveOperationException e) {
             e.printStackTrace();
             fail("Impossible to mock left/right hand database: " + e.getMessage());