Changeset 10179 in josm for trunk/src/org/openstreetmap/josm/plugins

Timestamp:

2016-05-11T02:44:10+02:00 (6 years ago)

Author:

Don-vip

Message:

sonar - squid:AssignmentInSubExpressionCheck - Assignments should not be made from within sub-expressions

File:

• trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -1493 +1493 @@
 
     private static class UpdatePluginsMessagePanel extends JPanel {
-        private JMultilineLabel lblMessage;
-        private JCheckBox cbDontShowAgain;
+        private final JMultilineLabel lblMessage = new JMultilineLabel("");
+        private final JCheckBox cbDontShowAgain = new JCheckBox(
+                tr("Do not ask again and remember my decision (go to Preferences->Plugins to change it later)"));
+
+        UpdatePluginsMessagePanel() {
+            build();
+        }
 
         protected final void build() {
@@ -1504 +1509 @@
             gc.weighty = 1.0;
             gc.insets = new Insets(5, 5, 5, 5);
-            add(lblMessage = new JMultilineLabel(""), gc);
+            add(lblMessage, gc);
             lblMessage.setFont(lblMessage.getFont().deriveFont(Font.PLAIN));
 
@@ -1510 +1515 @@
             gc.fill = GridBagConstraints.HORIZONTAL;
             gc.weighty = 0.0;
-            add(cbDontShowAgain = new JCheckBox(
-                    tr("Do not ask again and remember my decision (go to Preferences->Plugins to change it later)")), gc);
+            add(cbDontShowAgain, gc);
             cbDontShowAgain.setFont(cbDontShowAgain.getFont().deriveFont(Font.PLAIN));
-        }
-
-        UpdatePluginsMessagePanel() {
-            build();
         }