Changeset 10179 in josm for trunk/src/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreference.java

Timestamp:

2016-05-11T02:44:10+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:AssignmentInSubExpressionCheck - Assignments should not be made from within sub-expressions

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreference.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreference.java

@@ -79 +79 @@
     private ImageryLayerInfo layerInfo;
 
-    private CommonSettingsPanel commonSettings;
-    private WMSSettingsPanel wmsSettings;
-    private TMSSettingsPanel tmsSettings;
+    private final CommonSettingsPanel commonSettings = new CommonSettingsPanel();
+    private final WMSSettingsPanel wmsSettings = new WMSSettingsPanel();
+    private final TMSSettingsPanel tmsSettings = new TMSSettingsPanel();
 
     /**
@@ -115 +115 @@
         p.setBorder(BorderFactory.createEmptyBorder(5, 5, 5, 5));
 
-        addSettingsSection(p, tr("Common Settings"), commonSettings = new CommonSettingsPanel());
-        addSettingsSection(p, tr("WMS Settings"), wmsSettings = new WMSSettingsPanel(),
+        addSettingsSection(p, tr("Common Settings"), commonSettings);
+        addSettingsSection(p, tr("WMS Settings"), wmsSettings,
                 GBC.eol().fill(GBC.HORIZONTAL));
-        addSettingsSection(p, tr("TMS Settings"), tmsSettings = new TMSSettingsPanel(),
+        addSettingsSection(p, tr("TMS Settings"), tmsSettings,
                 GBC.eol().fill(GBC.HORIZONTAL));