Changeset 10127 in josm for trunk/test/unit/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialogTest.java

Timestamp:

2016-04-09T19:12:05+02:00 (8 years ago)

Author:

Don-vip

Message:

sort primitives to avoid intermittent unit test failures

File:

• trunk/test/unit/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialogTest.java (modified) (6 diffs)

trunk/test/unit/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialogTest.java

@@ -3 +3 @@
 
 import static org.junit.Assert.assertEquals;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
 
 import org.junit.BeforeClass;
@@ -10 +14 @@
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.Node;
+import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.data.osm.OsmPrimitiveComparator;
 import org.openstreetmap.josm.data.osm.Way;
 
@@ -23 +29 @@
     public static void setUpBeforeClass() {
         JOSMFixture.createUnitTestFixture().init();
+    }
+
+    private static String createSearchSetting(DataSet ds, boolean sameType) {
+        List<OsmPrimitive> sel = new ArrayList<>(ds.allPrimitives());
+        Collections.sort(sel, new OsmPrimitiveComparator(true, false));
+        return PropertiesDialog.createSearchSetting("foo", sel, sameType).text;
     }
 
@@ -39 +51 @@
             ds.addPrimitive(n);
         }
-        assertEquals("(\"foo\"=\"bar\")",
-                PropertiesDialog.createSearchSetting("foo", ds.allPrimitives(), false).text);
+        assertEquals("(\"foo\"=\"bar\")", createSearchSetting(ds, false));
 
         Node n = new Node(LatLon.ZERO);
@@ -46 +57 @@
         ds.addPrimitive(n);
 
-        assertEquals("(\"foo\"=\"bar\") OR (\"foo\"=\"baz\")",
-                PropertiesDialog.createSearchSetting("foo", ds.allPrimitives(), false).text);
+        assertEquals("(\"foo\"=\"baz\") OR (\"foo\"=\"bar\")", createSearchSetting(ds, false));
 
         ds.removePrimitive(n);
@@ -55 +65 @@
         ds.addPrimitive(w);
 
-        assertEquals("(type:node \"foo\"=\"bar\") OR (type:way \"foo\"=\"bar\")",
-                PropertiesDialog.createSearchSetting("foo", ds.allPrimitives(), true).text);
+        assertEquals("(type:way \"foo\"=\"bar\") OR (type:node \"foo\"=\"bar\")", createSearchSetting(ds, true));
     }
 }