Changeset 10043 in josm for trunk/src/org/openstreetmap/josm/data/validation

Timestamp:

2016-03-26T14:45:25+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S2325 - "private" methods that don't access instance data should be "static"

Location:

trunk/src/org/openstreetmap/josm/data/validation/tests

Files:

• OpeningHourTest.java (modified) (1 diff)
• OverlappingWays.java (modified) (1 diff)
• RelationChecker.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/OpeningHourTest.java

@@ -231 +231 @@
      * @return translated/shortened error/warnign message
      */
-    private String getErrorMessage(String key, Object o) {
+    private static String getErrorMessage(String key, Object o) {
         String msg = o.toString().trim()
         .replace("Unexpected token:", tr("Unexpected token:"))

trunk/src/org/openstreetmap/josm/data/validation/tests/OverlappingWays.java

@@ -67 +67 @@
     }
 
-    private boolean parentMultipolygonConcernsArea(OsmPrimitive p) {
+    private static boolean parentMultipolygonConcernsArea(OsmPrimitive p) {
         for (Relation r : OsmPrimitive.getFilteredList(p.getReferrers(), Relation.class)) {
             if (r.concernsArea()) {

trunk/src/org/openstreetmap/josm/data/validation/tests/RelationChecker.java

@@ -126 +126 @@
     }
 
-    private Map<String, RoleInfo> buildRoleInfoMap(Relation n) {
+    private static Map<String, RoleInfo> buildRoleInfoMap(Relation n) {
         Map<String, RoleInfo> map = new HashMap<>();
         for (RelationMember m : n.getMembers()) {
@@ -141 +141 @@
 
     // return Roles grouped by key
-    private Map<String, RolePreset> buildAllRoles(Relation n) {
+    private static Map<String, RolePreset> buildAllRoles(Relation n) {
         Map<String, RolePreset> allroles = new HashMap<>();