source: josm/trunk/data/validator/geometry.mapcss

Last change on this file was 14593, checked in by Klumbumbus, 4 weeks ago

fix #15774 - Update emergency=fire_hydrant preset (based on patch by elgolfo and bus-mt), add a bunch of validator checks

  • Property svn:eol-style set to native
File size: 13.9 KB
Line 
1/* {0} on a node, should be a way */
2node[area=no],
3node[oneway],
4node[bridge],
5node[sidewalk],
6node[footway],
7node[man_made=embankment],
8node[man_made=groyne],
9node[man_made=cutline],
10node[power=line],
11node[cutline],
12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
38node[waterway=drain],
39node[natural=coastline],
40node[natural=ridge],
41node[natural=valley],
42node[natural=tree_row] {
43  throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
44  assertMatch: "node oneway=-1";
45  assertNoMatch: "way oneway=-1";
46  assertMatch: "node bridge=yes";
47  assertMatch: "node bridge=viaduct";
48}
49
50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52  throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
55/* {0} on a node, should be an area; #10679 #16528 #16792 */
56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
59node[area=yes],
60node[area:highway],
61node[landuse],
62node[natural=scree],
63node[natural=scrub],
64node[natural=fell],
65node[natural=heath],
66node[natural=wood],
67node[natural=grassland],
68node[natural=wetland],
69node[natural=water],
70node[natural=mud],
71node[natural=beach],
72node[natural=sand],
73node[natural=wood],
74node[natural=bare_rock],
75node[natural=glacier],
76node[waterway=riverbank],
77node[man_made=bridge],
78node[man_made=breakwater],
79node[aeroway=apron],
80node[power=plant],
81node[power=switchgear],
82node[building:part],
83node[source:outline] {
84  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
85}
86
87/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
88node[type=multipolygon],
89node[route],
90node[restriction] {
91  throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}"); 
92}
93
94/* {0} on a way, should be a node */
95way[emergency=fire_hydrant],
96way[entrance],
97way[door],
98way[railway=subway_entrance],
99way[man_made=survey_point],
100way[aeroway=holding_position],
101way[power=transformer],
102way[power=pole],
103way[power=catenary_mast],
104way[power=terminal],
105way[power=tower]!:closed,
106way[amenity=vending_machine],
107way[natural=peak],
108way[natural=saddle],
109way[natural=volcano],
110way[natural=tree],
111way[highway=give_way],
112way[highway=milestone],
113way[highway=mini_roundabout],
114way[highway=stop],
115way[highway=street_lamp],
116way[highway=traffic_signals],
117way[highway=turning_loop],
118way[highway=turning_circle],
119way[highway=motorway_junction] {
120  throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}"); 
121}
122
123/* {0} on a way, should be a relation; see #15642, #10252, #14288 */
124way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
125way[type=multipolygon],
126way[route=bus] {
127  throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}"); 
128}
129
130/* #14395 */
131way >[index=1] node,
132way >[index=-1] node {
133  set first_last_node;
134}
135way[highway][area!=yes][!tunnel][!covered] > node {
136  set node_in_highway;
137}
138way[building][building!=no] > node.node_in_highway!.first_last_node {
139  throwWarning: tr("node connects highway and building");
140}
141
142/* #15035, must not warn for node 3815077900*/
143node[man_made!=monitoring_station][at(0.0,0.0)] {
144  throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
145  fixDeleteObject: this;
146}
147
148/* #12502 */
149node[leisure=park][natural=tree] {
150  throwWarning: tr("{0} together with {1} on a node. Remove {0}.", "{0.tag}", "{1.tag}");
151  group: tr("suspicious tag combination");
152  fixRemove: "leisure";
153}
154node[leisure=park][natural!=tree] {
155  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
156}
157
158/* see ticket:#10125 */
159node[source:geometry] {
160  throwWarning: tr("{0} on a node", "{0.key}");
161  fixChangeKey: "source:geometry => source:position";
162}
163
164/* Building inside building (spatial test) */
165*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")] 
166*[building][building!~/no|entrance/] {
167  throwWarning: tr("Building inside building");
168}
169
170/* Overlapping areas (spatial test) */
171area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
172  set water_area;
173}
174
175/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
176area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/]  area:closed:areaStyle.water_area,
177area:closed:areaStyle[landuse=reservoir]                         area:closed:areaStyle.water_area {
178  throwWarning: tr("Overlapping Water Areas");
179}
180
181area:closed:areaStyle  area:closed:areaStyle {
182  throwOther: tr("Overlapping Areas");
183}
184
185/* see ticket #9311 */
186node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/]  *[amenity=parking] {
187  throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
188  group: tr("{0} inside {1}", "amenity", "amenity");
189}
190
191/* see ticket #9556 */
192area:closed:areaStyle[tag("natural") = parent_tag("natural")]  area:closed:areaStyle[natural] {
193  throwWarning: tr("Overlapping Identical Natural Areas");
194}
195
196area:closed:areaStyle[landuse!=residential][tag("landuse") = parent_tag("landuse")]  area:closed:areaStyle[landuse][landuse!=residential] {
197  throwWarning: tr("Overlapping Identical Landuses");
198}
199
200/* see ticket:#9522 */
201node[tag("amenity") = parent_tag("amenity")]  *[amenity][amenity != parking] {
202  throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
203  group: tr("{0} inside {1}", "amenity", "amenity");
204}
205node[tag("leisure") = parent_tag("leisure")]  *[leisure] {
206  throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
207  group: tr("{0} inside {1}", "leisure", "leisure");
208}
209node[tag("tourism") = parent_tag("tourism")]  *[tourism] {
210  throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
211  group: tr("{0} inside {1}", "tourism", "tourism");
212}
213node[tag("shop") = parent_tag("shop")]  *[shop] {
214  throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
215  group: tr("{0} inside {1}", "shop", "shop");
216}
217node[tag("power") = parent_tag("power")]  *[power] {
218  throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
219  group: tr("{0} inside {1}", "power", "power");
220}
221
222/* isolated nodes which should be part of a way, see #10825, #15478 */
223node:unconnected:in-downloaded-area[entrance],
224node:unconnected:in-downloaded-area[traffic_calming],
225node:unconnected:in-downloaded-area[highway=passing_place],
226node:unconnected:in-downloaded-area[highway=mini_roundabout],
227node:unconnected:in-downloaded-area[highway=motorway_junction],
228node:unconnected:in-downloaded-area[highway=turning_loop],
229node:unconnected:in-downloaded-area[highway=turning_circle],
230node:unconnected:in-downloaded-area[highway=stop],
231node:unconnected:in-downloaded-area[highway=give_way],
232node:unconnected:in-downloaded-area[highway=traffic_signals],
233node:unconnected:in-downloaded-area[highway=crossing],
234node:unconnected:in-downloaded-area[crossing],
235node:unconnected:in-downloaded-area[highway=milestone],
236node:unconnected:in-downloaded-area[railway=milestone],
237node:unconnected:in-downloaded-area[railway=crossing],
238node:unconnected:in-downloaded-area[railway=level_crossing],
239node:unconnected:in-downloaded-area[railway=buffer_stop],
240node:unconnected:in-downloaded-area[public_transport=stop_position],
241node:unconnected:in-downloaded-area[aeroway=holding_position],
242node:unconnected:in-downloaded-area[noexit],
243node:unconnected:in-downloaded-area[waterway=dam],
244node:unconnected:in-downloaded-area[waterway=weir],
245node:unconnected:in-downloaded-area[waterway=waterfall],
246node:unconnected:in-downloaded-area[amenity=ferry_terminal],
247node:unconnected:in-downloaded-area[leisure=slipway],
248node:unconnected:in-downloaded-area[mountain_pass=yes],
249node:unconnected:in-downloaded-area[barrier=gate],
250node:unconnected:in-downloaded-area[barrier=lift_gate],
251node:unconnected:in-downloaded-area[barrier=swing_gate],
252node:unconnected:in-downloaded-area[barrier=toll_booth],
253node:unconnected:in-downloaded-area[barrier=turnstile],
254node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
255node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
256node:unconnected:in-downloaded-area[barrier=rope],
257node:unconnected:in-downloaded-area[barrier=sally_port],
258node:unconnected:in-downloaded-area[barrier=spikes],
259node:unconnected:in-downloaded-area[barrier=stile],
260node:unconnected:in-downloaded-area[barrier=sump_buster],
261node:unconnected:in-downloaded-area[barrier=kerb],
262node:unconnected:in-downloaded-area[barrier=border_control],
263node:unconnected:in-downloaded-area[barrier=bump_gate],
264node:unconnected:in-downloaded-area[barrier=bus_trap],
265node:unconnected:in-downloaded-area[barrier=cattle_grid],
266node:unconnected:in-downloaded-area[barrier=chain],
267node:unconnected:in-downloaded-area[barrier=cycle_barrier],
268node:unconnected:in-downloaded-area[barrier=hampshire_gate],
269node:unconnected:in-downloaded-area[barrier=height_restrictor],
270node:unconnected:in-downloaded-area[barrier=debris] {
271  throwWarning: tr("{0}", "{2.tag}");
272  group: tr("isolated node which must be connected to a way");
273}
274
275/* #11127 */
276way[railway][bridge] > node,
277way[highway][bridge] > node {
278  set node_in_bridge;
279}
280way[waterway] > node.node_in_bridge {
281  throwWarning: tr("node connects waterway and bridge");
282}
283
284/* #11128, #14812, #15032 */
285way[highway] > node[tourism=information][information=guidepost] {
286  set guidepost;
287  throwOther: tr("{0} node connected to a highway", "{1.tag}");
288}
289way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge|taxi)$/],
290way[highway] > node[building][!entrance],
291way[highway] > node[leisure][!entrance][leisure!=slipway],
292way[highway] > node[office][!entrance],
293way[highway] > node[shop][!entrance],
294way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
295way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
296  throwWarning: tr("{0} node connected to a highway", "{0.key}");
297}
298
299way[junction=roundabout]:righthandtraffic:clockwise,
300way[junction=roundabout]!:righthandtraffic:anticlockwise {
301  throwWarning: tr("suspicious roundabout direction");
302}
303
304/* #12496 */
305area:closed[place=islet][eval(areasize()) > 1500000] {
306  throwWarning: tr("{0} on a large area", "{1.tag}");
307  suggestAlternative: "place=island";
308  fixAdd: "place=island";
309}
310
311area:closed[place=island][eval(areasize()) < 500000] {
312  throwWarning: tr("{0} on a small area", "{1.tag}");
313  suggestAlternative: "place=islet";
314  fixAdd: "place=islet";
315}
316
317/* #15648 */
318way[place=island]!:closed {
319  throwError: tr("Way with {0} not closed.", "{0.tag}");
320}
321
322/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
323area:closed[building][building!=no][eval(areasize()) > 520000] {
324  throwError: tr("Too large building");
325}
326
327/* #12577 */
328way[power=line] > node,
329way[power=minor_line] > node,
330way[power=cable] > node {
331  set node_in_power_way;
332}
333way[!power][!building] > node.node_in_power_way {
334  throwWarning: tr("Node connects a power line or cable with an object which is not related to the power infrastructure.");
335}
336
337/* #12646, #12992 */
338way[waterway=~/^(stream|ditch|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area { 
339  throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
340}
341
342/* #10717, #14535 */
343way:closed[natural=coastline]  area[natural=water],
344way:closed[natural=coastline]  area[waterway=riverbank] {
345  throwError: tr("Coastline inside {1}", "{0.tag}");
346}
347
348/* #10471 */
349way[waterway] > node[ford?] { set ford_on_waterway; }
350way[highway] > node[ford?] { set ford_on_highway; }
351node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
352    throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
353}
354
355/* #13877 */
356area:closed[waterway = canal][area!=no],
357area:closed[waterway = drain][area!=no],
358area:closed[waterway = ditch][area!=no],
359area:closed[waterway = stream][area!=no],
360area:closed[waterway = river][area!=no] {
361  throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
362}
363
364/* #15097 */
365way[highway][area!=yes] > node,
366way[man_made=pier] > node {
367  set node_in_highway_pier;
368}
369way[route=ferry][tunnel=yes] > node,
370way[route=ferry][bridge=yes] > node {
371  set node_in_ferry_bridge_tunnel;
372}
373way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
374way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
375  throwWarning: tr("Ferry route is not connected to the road network or branches.");
376}
377way[amenity=ferry_terminal] > node,
378way[man_made=pier] > node {
379  set node_in_terminal_pier;
380}
381way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
382way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
383  throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
384}
Note: See TracBrowser for help on using the repository browser.