1 | // License: GPL. For details, see LICENSE file.
|
---|
2 | package org.openstreetmap.josm.data.validation.tests;
|
---|
3 |
|
---|
4 | import java.util.ArrayList;
|
---|
5 | import java.util.List;
|
---|
6 | import java.util.stream.Collectors;
|
---|
7 | import java.util.stream.IntStream;
|
---|
8 |
|
---|
9 | import org.junit.Assert;
|
---|
10 | import org.junit.BeforeClass;
|
---|
11 | import org.junit.Test;
|
---|
12 | import org.openstreetmap.josm.JOSMFixture;
|
---|
13 | import org.openstreetmap.josm.data.coor.LatLon;
|
---|
14 | import org.openstreetmap.josm.data.osm.Node;
|
---|
15 | import org.openstreetmap.josm.data.osm.OsmUtils;
|
---|
16 | import org.openstreetmap.josm.data.osm.Way;
|
---|
17 |
|
---|
18 | /**
|
---|
19 | * JUnit Test of Multipolygon validation test.
|
---|
20 | */
|
---|
21 | public class SelfIntersectingWayTest {
|
---|
22 |
|
---|
23 | /**
|
---|
24 | * Setup test.
|
---|
25 | * @throws Exception if test cannot be initialized
|
---|
26 | */
|
---|
27 | @BeforeClass
|
---|
28 | public static void setUp() throws Exception {
|
---|
29 | JOSMFixture.createUnitTestFixture().init();
|
---|
30 | }
|
---|
31 |
|
---|
32 | private static List<Node> createNodes() {
|
---|
33 | List<Node> nodes = IntStream.range(0, 6).mapToObj(i -> new Node(i + 1)).collect(Collectors.toList());
|
---|
34 | nodes.get(0).setCoor(new LatLon(34.2680, 133.563));
|
---|
35 | nodes.get(1).setCoor(new LatLon(34.2509, 133.548));
|
---|
36 | nodes.get(2).setCoor(new LatLon(34.2446, 133.566));
|
---|
37 | nodes.get(3).setCoor(new LatLon(34.2681, 133.560));
|
---|
38 | nodes.get(4).setCoor(new LatLon(34.2656, 133.561));
|
---|
39 | nodes.get(5).setCoor(new LatLon(34.2655, 133.562));
|
---|
40 | return nodes;
|
---|
41 | }
|
---|
42 |
|
---|
43 | /**
|
---|
44 | * Self-Intersection at inner node (not first / last).
|
---|
45 | */
|
---|
46 | @Test
|
---|
47 | public void testUnclosedWayNormal() {
|
---|
48 | List<Node> nodes = createNodes();
|
---|
49 |
|
---|
50 | Way w = (Way) OsmUtils.createPrimitive("way ");
|
---|
51 | List<Node> wayNodes = new ArrayList<>();
|
---|
52 | wayNodes.add(nodes.get(0));
|
---|
53 | wayNodes.add(nodes.get(1));
|
---|
54 | wayNodes.add(nodes.get(2));
|
---|
55 | wayNodes.add(nodes.get(1)); // problem
|
---|
56 | wayNodes.add(nodes.get(3));
|
---|
57 | wayNodes.add(nodes.get(4));
|
---|
58 | w.setNodes(wayNodes);
|
---|
59 | SelfIntersectingWay test = new SelfIntersectingWay();
|
---|
60 | test.visit(w);
|
---|
61 | Assert.assertEquals(1, test.getErrors().size());
|
---|
62 | Assert.assertTrue(test.getErrors().iterator().next().getHighlighted().contains(nodes.get(1)));
|
---|
63 | }
|
---|
64 |
|
---|
65 | /**
|
---|
66 | * First node is identical to an inner node ("P"-Shape).
|
---|
67 | * This is considered okay.
|
---|
68 | */
|
---|
69 | @Test
|
---|
70 | public void testUnclosedWayFirst() {
|
---|
71 | List<Node> nodes = createNodes();
|
---|
72 |
|
---|
73 | Way w = (Way) OsmUtils.createPrimitive("way ");
|
---|
74 | List<Node> wayNodes = new ArrayList<>();
|
---|
75 | wayNodes.add(nodes.get(0));
|
---|
76 | wayNodes.add(nodes.get(1));
|
---|
77 | wayNodes.add(nodes.get(2));
|
---|
78 | wayNodes.add(nodes.get(0)); // problem
|
---|
79 | wayNodes.add(nodes.get(3));
|
---|
80 | wayNodes.add(nodes.get(4));
|
---|
81 | w.setNodes(wayNodes);
|
---|
82 | SelfIntersectingWay test = new SelfIntersectingWay();
|
---|
83 | test.visit(w);
|
---|
84 | Assert.assertEquals(0, test.getErrors().size());
|
---|
85 | }
|
---|
86 |
|
---|
87 | /**
|
---|
88 | * First node is identical to an inner node ("P"-Shape).
|
---|
89 | * This is considered okay.
|
---|
90 | */
|
---|
91 | @Test
|
---|
92 | public void testUnclosedWayFirstRepeated() {
|
---|
93 | List<Node> nodes = createNodes();
|
---|
94 |
|
---|
95 | Way w = (Way) OsmUtils.createPrimitive("way ");
|
---|
96 | List<Node> wayNodes = new ArrayList<>();
|
---|
97 | wayNodes.add(nodes.get(0));
|
---|
98 | wayNodes.add(nodes.get(1));
|
---|
99 | wayNodes.add(nodes.get(2));
|
---|
100 | wayNodes.add(nodes.get(0));
|
---|
101 | wayNodes.add(nodes.get(3));
|
---|
102 | wayNodes.add(nodes.get(4));
|
---|
103 | w.setNodes(wayNodes);
|
---|
104 | SelfIntersectingWay test = new SelfIntersectingWay();
|
---|
105 | test.visit(w);
|
---|
106 | Assert.assertEquals(0, test.getErrors().size());
|
---|
107 | }
|
---|
108 |
|
---|
109 | /**
|
---|
110 | * Last node is identical to an inner node ("b"-Shape).
|
---|
111 | * This is considered okay.
|
---|
112 | */
|
---|
113 | @Test
|
---|
114 | public void testUnclosedWayLast() {
|
---|
115 | List<Node> nodes = createNodes();
|
---|
116 |
|
---|
117 | Way w = (Way) OsmUtils.createPrimitive("way ");
|
---|
118 | List<Node> wayNodes = new ArrayList<>();
|
---|
119 | wayNodes.add(nodes.get(0));
|
---|
120 | wayNodes.add(nodes.get(1)); // problem node
|
---|
121 | wayNodes.add(nodes.get(2));
|
---|
122 | wayNodes.add(nodes.get(3));
|
---|
123 | wayNodes.add(nodes.get(4));
|
---|
124 | wayNodes.add(nodes.get(1));
|
---|
125 | w.setNodes(wayNodes);
|
---|
126 | SelfIntersectingWay test = new SelfIntersectingWay();
|
---|
127 | test.visit(w);
|
---|
128 | Assert.assertEquals(0, test.getErrors().size());
|
---|
129 | }
|
---|
130 |
|
---|
131 | /**
|
---|
132 | * Both endpoints join at one inner node ("8"-shape).
|
---|
133 | * This is considered to be an error.
|
---|
134 | */
|
---|
135 | @Test
|
---|
136 | public void testClosedWay() {
|
---|
137 | List<Node> nodes = createNodes();
|
---|
138 |
|
---|
139 | Way w = (Way) OsmUtils.createPrimitive("way ");
|
---|
140 | List<Node> wayNodes = new ArrayList<>();
|
---|
141 | wayNodes.add(nodes.get(0));
|
---|
142 | wayNodes.add(nodes.get(1));
|
---|
143 | wayNodes.add(nodes.get(2));
|
---|
144 | wayNodes.add(nodes.get(0)); // problem
|
---|
145 | wayNodes.add(nodes.get(3));
|
---|
146 | wayNodes.add(nodes.get(4));
|
---|
147 | wayNodes.add(nodes.get(0));
|
---|
148 | w.setNodes(wayNodes);
|
---|
149 | SelfIntersectingWay test = new SelfIntersectingWay();
|
---|
150 | test.visit(w);
|
---|
151 | Assert.assertEquals(1, test.getErrors().size());
|
---|
152 | Assert.assertTrue(test.getErrors().iterator().next().getHighlighted().contains(nodes.get(0)));
|
---|
153 | }
|
---|
154 |
|
---|
155 | /**
|
---|
156 | * Closed way contains a spike.
|
---|
157 | * This is considered to be an error.
|
---|
158 | */
|
---|
159 | @Test
|
---|
160 | public void testSpikeWithStartInClosedWay() {
|
---|
161 | List<Node> nodes = createNodes();
|
---|
162 |
|
---|
163 | Way w = (Way) OsmUtils.createPrimitive("way ");
|
---|
164 | List<Node> wayNodes = new ArrayList<>();
|
---|
165 | wayNodes.add(nodes.get(0));
|
---|
166 | wayNodes.add(nodes.get(1));
|
---|
167 | wayNodes.add(nodes.get(0)); // problem
|
---|
168 | wayNodes.add(nodes.get(3));
|
---|
169 | wayNodes.add(nodes.get(4));
|
---|
170 | wayNodes.add(nodes.get(0));
|
---|
171 | w.setNodes(wayNodes);
|
---|
172 | SelfIntersectingWay test = new SelfIntersectingWay();
|
---|
173 | test.visit(w);
|
---|
174 | Assert.assertEquals(1, test.getErrors().size());
|
---|
175 | Assert.assertTrue(test.getErrors().iterator().next().getHighlighted().contains(nodes.get(0)));
|
---|
176 | }
|
---|
177 |
|
---|
178 | /**
|
---|
179 | * Closed way contains a spike.
|
---|
180 | * This is considered to be an error.
|
---|
181 | */
|
---|
182 | @Test
|
---|
183 | public void testSpikeWithEndInClosedWay() {
|
---|
184 | List<Node> nodes = createNodes();
|
---|
185 |
|
---|
186 | Way w = (Way) OsmUtils.createPrimitive("way ");
|
---|
187 | List<Node> wayNodes = new ArrayList<>();
|
---|
188 | wayNodes.add(nodes.get(0));
|
---|
189 | wayNodes.add(nodes.get(1));
|
---|
190 | wayNodes.add(nodes.get(2));
|
---|
191 | wayNodes.add(nodes.get(0)); // problem
|
---|
192 | wayNodes.add(nodes.get(3));
|
---|
193 | wayNodes.add(nodes.get(0));
|
---|
194 | w.setNodes(wayNodes);
|
---|
195 | SelfIntersectingWay test = new SelfIntersectingWay();
|
---|
196 | test.visit(w);
|
---|
197 | Assert.assertEquals(1, test.getErrors().size());
|
---|
198 | Assert.assertTrue(test.getErrors().iterator().next().getHighlighted().contains(nodes.get(0)));
|
---|
199 | }
|
---|
200 |
|
---|
201 | /**
|
---|
202 | * Closed way contains a spike.
|
---|
203 | * This is considered to be an error.
|
---|
204 | */
|
---|
205 | @Test
|
---|
206 | public void testSpikeInClosedWay() {
|
---|
207 | List<Node> nodes = createNodes();
|
---|
208 |
|
---|
209 | Way w = (Way) OsmUtils.createPrimitive("way ");
|
---|
210 | List<Node> wayNodes = new ArrayList<>();
|
---|
211 | wayNodes.add(nodes.get(0));
|
---|
212 | wayNodes.add(nodes.get(1));
|
---|
213 | wayNodes.add(nodes.get(2));
|
---|
214 | wayNodes.add(nodes.get(3));
|
---|
215 | wayNodes.add(nodes.get(2));
|
---|
216 | wayNodes.add(nodes.get(0));
|
---|
217 | w.setNodes(wayNodes);
|
---|
218 | SelfIntersectingWay test = new SelfIntersectingWay();
|
---|
219 | test.visit(w);
|
---|
220 | Assert.assertEquals(1, test.getErrors().size());
|
---|
221 | Assert.assertTrue(test.getErrors().iterator().next().getHighlighted().contains(nodes.get(2)));
|
---|
222 | }
|
---|
223 |
|
---|
224 | /**
|
---|
225 | * Closed way with barbell shape (a-b-c-a-d-e-f-d).
|
---|
226 | * This is considered to be an error.
|
---|
227 | */
|
---|
228 | @Test
|
---|
229 | public void testClosedWayBarbell() {
|
---|
230 | List<Node> nodes = createNodes();
|
---|
231 |
|
---|
232 | Way w = (Way) OsmUtils.createPrimitive("way ");
|
---|
233 | List<Node> wayNodes = new ArrayList<>();
|
---|
234 | wayNodes.add(nodes.get(0));
|
---|
235 | wayNodes.add(nodes.get(1));
|
---|
236 | wayNodes.add(nodes.get(2));
|
---|
237 | wayNodes.add(nodes.get(0));
|
---|
238 | wayNodes.add(nodes.get(3));
|
---|
239 | wayNodes.add(nodes.get(4));
|
---|
240 | wayNodes.add(nodes.get(5));
|
---|
241 | wayNodes.add(nodes.get(3));
|
---|
242 | w.setNodes(wayNodes);
|
---|
243 | SelfIntersectingWay test = new SelfIntersectingWay();
|
---|
244 | test.visit(w);
|
---|
245 | Assert.assertEquals(1, test.getErrors().size());
|
---|
246 | Assert.assertTrue(test.getErrors().iterator().next().getHighlighted().contains(nodes.get(3)));
|
---|
247 | }
|
---|
248 |
|
---|
249 | }
|
---|