1 | // License: GPL. For details, see LICENSE file.
|
---|
2 | package org.openstreetmap.josm.data.validation.tests;
|
---|
3 |
|
---|
4 | import static org.junit.Assert.assertEquals;
|
---|
5 | import static org.junit.Assert.assertTrue;
|
---|
6 | import static org.openstreetmap.josm.data.osm.OsmUtils.createPrimitive;
|
---|
7 |
|
---|
8 | import java.util.List;
|
---|
9 |
|
---|
10 | import org.junit.Rule;
|
---|
11 | import org.junit.Test;
|
---|
12 | import org.openstreetmap.josm.data.osm.Node;
|
---|
13 | import org.openstreetmap.josm.data.osm.OsmUtils;
|
---|
14 | import org.openstreetmap.josm.data.osm.Relation;
|
---|
15 | import org.openstreetmap.josm.data.osm.RelationMember;
|
---|
16 | import org.openstreetmap.josm.data.osm.Way;
|
---|
17 | import org.openstreetmap.josm.data.validation.TestError;
|
---|
18 | import org.openstreetmap.josm.testutils.JOSMTestRules;
|
---|
19 |
|
---|
20 | import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
|
---|
21 |
|
---|
22 | /**
|
---|
23 | * Unit tests of {@link RelationChecker} class.
|
---|
24 | */
|
---|
25 | public class RelationCheckerTest {
|
---|
26 | /**
|
---|
27 | * Setup test.
|
---|
28 | */
|
---|
29 | @Rule
|
---|
30 | @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
|
---|
31 | public JOSMTestRules rule = new JOSMTestRules().presets();
|
---|
32 |
|
---|
33 | private static RelationChecker getRelationChecker() {
|
---|
34 | RelationChecker checker = new RelationChecker();
|
---|
35 | checker.initialize();
|
---|
36 | return checker;
|
---|
37 | }
|
---|
38 |
|
---|
39 | private static List<TestError> testRelation(Relation r) {
|
---|
40 | RelationChecker checker = getRelationChecker();
|
---|
41 | checker.visit(r);
|
---|
42 | return checker.getErrors();
|
---|
43 | }
|
---|
44 |
|
---|
45 | private static Relation createRelation(String tags) {
|
---|
46 | return (Relation) createPrimitive("relation "+ tags);
|
---|
47 | }
|
---|
48 |
|
---|
49 | @Test
|
---|
50 | public void testUnknownType() {
|
---|
51 | Relation r = createRelation("type=foobar");
|
---|
52 | r.addMember(new RelationMember("", new Way()));
|
---|
53 | List<TestError> errors = testRelation(r);
|
---|
54 |
|
---|
55 | assertTrue(errors.size() >= 1);
|
---|
56 | assertEquals("Relation type is unknown", errors.get(0).getMessage());
|
---|
57 | }
|
---|
58 |
|
---|
59 | @Test
|
---|
60 | public void testEmpty() {
|
---|
61 | List<TestError> errors = testRelation(createRelation("type=multipolygon"));
|
---|
62 | assertEquals(1, errors.size());
|
---|
63 | assertEquals("Relation is empty", errors.get(0).getMessage());
|
---|
64 | }
|
---|
65 |
|
---|
66 | @Test
|
---|
67 | public void testNormal() {
|
---|
68 | Relation r = createRelation("type=multipolygon");
|
---|
69 | r.addMember(new RelationMember("outer", new Way()));
|
---|
70 | r.addMember(new RelationMember("inner", new Way()));
|
---|
71 | assertTrue(testRelation(r).isEmpty());
|
---|
72 | }
|
---|
73 |
|
---|
74 | @Test
|
---|
75 | public void testOuter2() {
|
---|
76 | Relation r = createRelation("type=multipolygon");
|
---|
77 | r.addMember(new RelationMember("outer", new Way()));
|
---|
78 | r.addMember(new RelationMember("outer2", new Way()));
|
---|
79 |
|
---|
80 | List<TestError> errors = testRelation(r);
|
---|
81 | assertEquals(1, errors.size());
|
---|
82 | assertEquals("Role 'outer2' is not among expected values 'outer/inner'", errors.get(0).getDescription());
|
---|
83 | }
|
---|
84 |
|
---|
85 | @Test
|
---|
86 | public void testRestrictionViaMissing() {
|
---|
87 | Relation r = createRelation("type=restriction");
|
---|
88 | r.addMember(new RelationMember("from", new Way()));
|
---|
89 | r.addMember(new RelationMember("to", new Way()));
|
---|
90 |
|
---|
91 | List<TestError> errors = testRelation(r);
|
---|
92 | assertEquals(1, errors.size());
|
---|
93 | assertEquals("Role 'via' missing", errors.get(0).getDescription());
|
---|
94 | }
|
---|
95 |
|
---|
96 | @Test
|
---|
97 | public void testRestrictionViaRelation() {
|
---|
98 | Relation r = createRelation("type=restriction");
|
---|
99 | r.addMember(new RelationMember("from", new Way()));
|
---|
100 | r.addMember(new RelationMember("to", new Way()));
|
---|
101 | r.addMember(new RelationMember("via", new Relation()));
|
---|
102 |
|
---|
103 | List<TestError> errors = testRelation(r);
|
---|
104 | assertEquals(1, errors.size());
|
---|
105 | assertEquals("Type 'relation' of relation member with role 'via' does not match accepted types 'node/way' in preset Turn Restriction",
|
---|
106 | errors.get(0).getDescription());
|
---|
107 | }
|
---|
108 |
|
---|
109 | @Test
|
---|
110 | public void testRestrictionTwoFrom() {
|
---|
111 | Relation r = createRelation("type=restriction");
|
---|
112 | r.addMember(new RelationMember("from", new Way()));
|
---|
113 | r.addMember(new RelationMember("from", new Way()));
|
---|
114 | r.addMember(new RelationMember("to", new Way()));
|
---|
115 | r.addMember(new RelationMember("via", new Way()));
|
---|
116 |
|
---|
117 | List<TestError> errors = testRelation(r);
|
---|
118 | assertEquals(1, errors.size());
|
---|
119 | assertEquals("Number of 'from' roles too high (2)", errors.get(0).getDescription());
|
---|
120 | }
|
---|
121 |
|
---|
122 | @Test
|
---|
123 | public void testRestrictionEmpty() {
|
---|
124 | Relation r = createRelation("type=restriction");
|
---|
125 | r.addMember(new RelationMember("from", new Way()));
|
---|
126 | r.addMember(new RelationMember("to", new Way()));
|
---|
127 | r.addMember(new RelationMember("via", new Way()));
|
---|
128 | r.addMember(new RelationMember("", new Way()));
|
---|
129 |
|
---|
130 | List<TestError> errors = testRelation(r);
|
---|
131 | assertEquals(1, errors.size());
|
---|
132 | assertTrue(errors.get(0).getDescription().startsWith("Empty role found when expecting one of"));
|
---|
133 | }
|
---|
134 |
|
---|
135 | @Test
|
---|
136 | public void testPowerMemberExpression() {
|
---|
137 | Relation r = createRelation("type=route route=power");
|
---|
138 | r.addMember(new RelationMember("", new Way()));
|
---|
139 |
|
---|
140 | List<TestError> errors = testRelation(r);
|
---|
141 | assertEquals(2, errors.size());
|
---|
142 | assertEquals("Role 'line' missing", errors.get(0).getDescription());
|
---|
143 | assertEquals("Empty role found when expecting one of 'line/substation'", errors.get(1).getDescription());
|
---|
144 | }
|
---|
145 |
|
---|
146 | @Test
|
---|
147 | public void testBuildingMemberExpression() {
|
---|
148 | Relation r = createRelation("type=building");
|
---|
149 | r.addMember(new RelationMember("outline", new Way()));
|
---|
150 | r.addMember(new RelationMember("part", new Way()));
|
---|
151 | r.addMember(new RelationMember("level_-12", new Relation()));
|
---|
152 | r.addMember(new RelationMember("level_0", new Relation()));
|
---|
153 | r.addMember(new RelationMember("level_12", new Relation()));
|
---|
154 | r.addMember(new RelationMember("level_x", new Relation())); // fails
|
---|
155 |
|
---|
156 | List<TestError> errors = testRelation(r);
|
---|
157 | assertEquals(1, errors.size());
|
---|
158 | assertEquals("Role 'level_x' is not among expected values 'outline/part/ridge/edge/entrance/level_-?\\d+'",
|
---|
159 | errors.get(0).getDescription());
|
---|
160 | }
|
---|
161 |
|
---|
162 | @Test
|
---|
163 | public void testHikingRouteMembers() {
|
---|
164 | Relation r = createRelation("type=route route=hiking");
|
---|
165 | r.addMember(new RelationMember("", OsmUtils.createPrimitive("way highway=path")));
|
---|
166 | r.addMember(new RelationMember("route", OsmUtils.createPrimitive("way highway=path"))); // fails
|
---|
167 | r.addMember(new RelationMember("guidepost", new Node())); // fails
|
---|
168 |
|
---|
169 | List<TestError> errors = testRelation(r);
|
---|
170 | assertEquals(2, errors.size());
|
---|
171 | assertEquals("Role of relation member does not match template expression 'information=guidepost' in preset Hiking Route",
|
---|
172 | errors.get(0).getDescription());
|
---|
173 | assertEquals("Role 'route' is not among expected values '<empty>/guidepost'", errors.get(1).getDescription());
|
---|
174 | }
|
---|
175 |
|
---|
176 | @Test
|
---|
177 | public void testRouteMemberExpression() {
|
---|
178 | Relation r = createRelation("type=route route=tram public_transport:version=2");
|
---|
179 | r.addMember(new RelationMember("", createPrimitive("way railway=tram")));
|
---|
180 | r.addMember(new RelationMember("stop", createPrimitive("node public_transport=stop_position tram=yes")));
|
---|
181 | r.addMember(new RelationMember("platform", createPrimitive("node public_transport=platform tram=yes")));
|
---|
182 | assertTrue(testRelation(r).isEmpty());
|
---|
183 |
|
---|
184 | r.addMember(new RelationMember("", createPrimitive("way no-rail-way=yes")));
|
---|
185 | assertEquals(1, testRelation(r).size());
|
---|
186 | assertEquals("Role of relation member does not match template expression 'railway' in preset Public Transport Route (Rail)",
|
---|
187 | testRelation(r).get(0).getDescription());
|
---|
188 |
|
---|
189 | r.removeMember(3);
|
---|
190 | r.addMember(new RelationMember("stop", createPrimitive("way no-rail-way=yes")));
|
---|
191 | assertEquals(1, testRelation(r).size());
|
---|
192 | assertEquals(
|
---|
193 | "Type 'way' of relation member with role 'stop' does not match accepted types 'node' in preset Public Transport Route (Rail)",
|
---|
194 | testRelation(r).get(0).getDescription());
|
---|
195 |
|
---|
196 | r.removeMember(3);
|
---|
197 | r.addMember(new RelationMember("stop", createPrimitive("node public_transport=stop_position bus=yes")));
|
---|
198 | assertEquals(1, testRelation(r).size());
|
---|
199 | assertEquals("Role of relation member does not match template expression 'public_transport=stop_position && "+
|
---|
200 | "(train=yes || subway=yes || monorail=yes || tram=yes || light_rail=yes)' in preset Public Transport Route (Rail)",
|
---|
201 | testRelation(r).get(0).getDescription());
|
---|
202 | }
|
---|
203 | }
|
---|