1 | // License: GPL. For details, see LICENSE file.
|
---|
2 | package org.openstreetmap.josm.data.osm.visitor;
|
---|
3 |
|
---|
4 | import static org.junit.Assert.assertEquals;
|
---|
5 | import static org.junit.Assert.assertNotNull;
|
---|
6 | import static org.junit.Assert.assertNull;
|
---|
7 | import static org.junit.Assert.assertTrue;
|
---|
8 |
|
---|
9 | import java.util.Collection;
|
---|
10 |
|
---|
11 | import org.junit.Rule;
|
---|
12 | import org.junit.Test;
|
---|
13 | import org.openstreetmap.josm.data.coor.LatLon;
|
---|
14 | import org.openstreetmap.josm.data.osm.DataSet;
|
---|
15 | import org.openstreetmap.josm.data.osm.Node;
|
---|
16 | import org.openstreetmap.josm.data.osm.OsmPrimitive;
|
---|
17 | import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
|
---|
18 | import org.openstreetmap.josm.data.osm.Relation;
|
---|
19 | import org.openstreetmap.josm.data.osm.RelationMember;
|
---|
20 | import org.openstreetmap.josm.data.osm.Way;
|
---|
21 | import org.openstreetmap.josm.testutils.JOSMTestRules;
|
---|
22 |
|
---|
23 | import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
|
---|
24 |
|
---|
25 | /**
|
---|
26 | * Unit tests for class {@link MergeSourceBuildingVisitor}.
|
---|
27 | */
|
---|
28 | public class MergeSourceBuildingVisitorTest {
|
---|
29 |
|
---|
30 | protected OsmPrimitive lookupByName(Collection<? extends OsmPrimitive> primitives, String name) {
|
---|
31 | if (primitives == null) return null;
|
---|
32 | if (name == null) return null;
|
---|
33 | for (OsmPrimitive primitive: primitives) {
|
---|
34 | if (name.equals(primitive.get("name")))
|
---|
35 | return primitive;
|
---|
36 | }
|
---|
37 | return null;
|
---|
38 | }
|
---|
39 |
|
---|
40 | /**
|
---|
41 | * Setup test.
|
---|
42 | */
|
---|
43 | @Rule
|
---|
44 | @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
|
---|
45 | public JOSMTestRules test = new JOSMTestRules();
|
---|
46 |
|
---|
47 | @Test
|
---|
48 | public void testNodes() {
|
---|
49 | DataSet source = new DataSet();
|
---|
50 | Node n1 = new Node(1);
|
---|
51 | Node n2 = new Node(new LatLon(10.0, 10.0));
|
---|
52 | n2.put("name", "n2");
|
---|
53 | Node n3 = new Node(3);
|
---|
54 | Node n4 = new Node(new LatLon(20.0, 20.0));
|
---|
55 | n4.put("name", "n4");
|
---|
56 | source.addPrimitive(n1);
|
---|
57 | source.addPrimitive(n2);
|
---|
58 | source.addPrimitive(n3);
|
---|
59 | source.addPrimitive(n4);
|
---|
60 | source.setSelected(n1, n2);
|
---|
61 |
|
---|
62 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
63 | DataSet hull = builder.build();
|
---|
64 | assertNotNull(hull);
|
---|
65 | assertEquals(2, hull.getNodes().size());
|
---|
66 |
|
---|
67 | OsmPrimitive p = hull.getPrimitiveById(1, OsmPrimitiveType.NODE);
|
---|
68 | assertNotNull(p);
|
---|
69 | assertEquals(p.getClass(), Node.class);
|
---|
70 |
|
---|
71 | p = hull.getPrimitiveById(3, OsmPrimitiveType.NODE);
|
---|
72 | assertNull(p);
|
---|
73 |
|
---|
74 | p = lookupByName(hull.getNodes(), "n2");
|
---|
75 | assertNotNull(p);
|
---|
76 |
|
---|
77 | p = lookupByName(hull.getNodes(), "n4");
|
---|
78 | assertNull(p);
|
---|
79 | }
|
---|
80 |
|
---|
81 | @Test
|
---|
82 | public void testOneWay() {
|
---|
83 | DataSet source = new DataSet();
|
---|
84 | Node n1 = new Node(1);
|
---|
85 | Node n2 = new Node(2);
|
---|
86 | Way w1 = new Way(3, 1);
|
---|
87 | w1.addNode(n1);
|
---|
88 | w1.addNode(n2);
|
---|
89 | source.addPrimitive(n1);
|
---|
90 | source.addPrimitive(n2);
|
---|
91 | source.addPrimitive(w1);
|
---|
92 | source.setSelected(w1);
|
---|
93 |
|
---|
94 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
95 | DataSet hull = builder.build();
|
---|
96 | assertNotNull(hull);
|
---|
97 | assertEquals(1, hull.getWays().size());
|
---|
98 | assertEquals(2, hull.getNodes().size());
|
---|
99 |
|
---|
100 | OsmPrimitive p = hull.getPrimitiveById(1, OsmPrimitiveType.NODE);
|
---|
101 | assertNotNull(p);
|
---|
102 | assertEquals(p.getClass(), Node.class);
|
---|
103 |
|
---|
104 | p = hull.getPrimitiveById(2, OsmPrimitiveType.NODE);
|
---|
105 | assertNotNull(p);
|
---|
106 | assertEquals(p.getClass(), Node.class);
|
---|
107 |
|
---|
108 | p = hull.getPrimitiveById(3, OsmPrimitiveType.WAY);
|
---|
109 | assertNotNull(p);
|
---|
110 | assertEquals(p.getClass(), Way.class);
|
---|
111 | }
|
---|
112 |
|
---|
113 | @Test
|
---|
114 | public void testOneWayNodesSelectedToo() {
|
---|
115 | DataSet source = new DataSet();
|
---|
116 | Node n1 = new Node(1);
|
---|
117 | Node n2 = new Node(2);
|
---|
118 | Way w1 = new Way(3, 1);
|
---|
119 | w1.addNode(n1);
|
---|
120 | w1.addNode(n2);
|
---|
121 | source.addPrimitive(n1);
|
---|
122 | source.addPrimitive(n2);
|
---|
123 | source.addPrimitive(w1);
|
---|
124 | source.setSelected(w1, n1, n2);
|
---|
125 |
|
---|
126 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
127 | DataSet hull = builder.build();
|
---|
128 | assertNotNull(hull);
|
---|
129 | assertEquals(1, hull.getWays().size());
|
---|
130 | assertEquals(2, hull.getNodes().size());
|
---|
131 |
|
---|
132 | OsmPrimitive p = hull.getPrimitiveById(1, OsmPrimitiveType.NODE);
|
---|
133 | assertNotNull(p);
|
---|
134 | assertEquals(p.getClass(), Node.class);
|
---|
135 |
|
---|
136 | p = hull.getPrimitiveById(2, OsmPrimitiveType.NODE);
|
---|
137 | assertNotNull(p);
|
---|
138 | assertEquals(p.getClass(), Node.class);
|
---|
139 |
|
---|
140 | p = hull.getPrimitiveById(3, OsmPrimitiveType.WAY);
|
---|
141 | assertNotNull(p);
|
---|
142 | assertEquals(p.getClass(), Way.class);
|
---|
143 | }
|
---|
144 |
|
---|
145 | @Test
|
---|
146 | public void testOneWayIncomplete() {
|
---|
147 | DataSet source = new DataSet();
|
---|
148 | Way w1 = new Way(3);
|
---|
149 | source.addPrimitive(w1);
|
---|
150 | source.setSelected(w1);
|
---|
151 |
|
---|
152 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
153 | DataSet hull = builder.build();
|
---|
154 | assertNotNull(hull);
|
---|
155 | assertEquals(1, hull.getWays().size());
|
---|
156 |
|
---|
157 | OsmPrimitive p = hull.getPrimitiveById(3, OsmPrimitiveType.WAY);
|
---|
158 | assertNotNull(p);
|
---|
159 | assertEquals(p.getClass(), Way.class);
|
---|
160 | assertTrue(p.isIncomplete());
|
---|
161 | }
|
---|
162 |
|
---|
163 | @Test
|
---|
164 | public void testOneRelationExistingMembersSelected() {
|
---|
165 | DataSet source = new DataSet();
|
---|
166 | Relation r1 = new Relation(1, 1);
|
---|
167 | Node n20 = new Node(20, 1);
|
---|
168 | n20.setCoor(LatLon.ZERO);
|
---|
169 | r1.addMember(new RelationMember("node-20", n20));
|
---|
170 | Way w30 = new Way(30, 1);
|
---|
171 | Node n21 = new Node(21);
|
---|
172 | w30.addNode(n21);
|
---|
173 | Node n22 = new Node(22);
|
---|
174 | w30.addNode(n22);
|
---|
175 | r1.addMember(new RelationMember("way-30", w30));
|
---|
176 | Relation r40 = new Relation(40);
|
---|
177 | r1.addMember(new RelationMember("relation-40", r40));
|
---|
178 | source.addPrimitive(n20);
|
---|
179 | source.addPrimitive(n21);
|
---|
180 | source.addPrimitive(n22);
|
---|
181 | source.addPrimitive(w30);
|
---|
182 | source.addPrimitive(r40);
|
---|
183 | source.addPrimitive(r1);
|
---|
184 | source.setSelected(r1, n20, w30, r40);
|
---|
185 |
|
---|
186 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
187 | DataSet hull = builder.build();
|
---|
188 | assertNotNull(hull);
|
---|
189 | assertEquals(1, hull.getWays().size());
|
---|
190 | assertEquals(3, hull.getNodes().size());
|
---|
191 | assertEquals(2, hull.getRelations().size());
|
---|
192 |
|
---|
193 | OsmPrimitive p = hull.getPrimitiveById(1, OsmPrimitiveType.RELATION);
|
---|
194 | assertNotNull(p);
|
---|
195 | assertEquals(p.getClass(), Relation.class);
|
---|
196 |
|
---|
197 | Way w = (Way) hull.getPrimitiveById(30, OsmPrimitiveType.WAY);
|
---|
198 | assertNotNull(w);
|
---|
199 | assertEquals(2, w.getNodesCount());
|
---|
200 | Node n = (Node) hull.getPrimitiveById(21, OsmPrimitiveType.NODE);
|
---|
201 | assertNotNull(n);
|
---|
202 | assertTrue(w.containsNode(n));
|
---|
203 |
|
---|
204 | n = (Node) hull.getPrimitiveById(22, OsmPrimitiveType.NODE);
|
---|
205 | assertNotNull(n);
|
---|
206 | assertTrue(w.containsNode(n));
|
---|
207 |
|
---|
208 | Relation r = (Relation) hull.getPrimitiveById(40, OsmPrimitiveType.RELATION);
|
---|
209 | assertNotNull(r);
|
---|
210 |
|
---|
211 | r = (Relation) hull.getPrimitiveById(1, OsmPrimitiveType.RELATION);
|
---|
212 | assertNotNull(r);
|
---|
213 | assertEquals(3, r.getMembersCount());
|
---|
214 | RelationMember m = new RelationMember("node-20", hull.getPrimitiveById(20, OsmPrimitiveType.NODE));
|
---|
215 | assertTrue(r.getMembers().contains(m));
|
---|
216 | m = new RelationMember("way-30", hull.getPrimitiveById(30, OsmPrimitiveType.WAY));
|
---|
217 | assertTrue(r.getMembers().contains(m));
|
---|
218 | m = new RelationMember("relation-40", hull.getPrimitiveById(40, OsmPrimitiveType.RELATION));
|
---|
219 | assertTrue(r.getMembers().contains(m));
|
---|
220 | }
|
---|
221 |
|
---|
222 | @Test
|
---|
223 | public void testOneRelationExistingMembersNotSelected() {
|
---|
224 | DataSet source = new DataSet();
|
---|
225 | Relation r1 = new Relation(1, 1);
|
---|
226 | Node n20 = new Node(20);
|
---|
227 | r1.addMember(new RelationMember("node-20", n20));
|
---|
228 | Way w30 = new Way(30, 1);
|
---|
229 | Node n21;
|
---|
230 | w30.addNode(n21 = new Node(21));
|
---|
231 | Node n22;
|
---|
232 | w30.addNode(n22 = new Node(22));
|
---|
233 | r1.addMember(new RelationMember("way-30", w30));
|
---|
234 | Relation r40 = new Relation(40);
|
---|
235 | r1.addMember(new RelationMember("relation-40", r40));
|
---|
236 | source.addPrimitive(n20);
|
---|
237 | source.addPrimitive(n21);
|
---|
238 | source.addPrimitive(n22);
|
---|
239 | source.addPrimitive(w30);
|
---|
240 | source.addPrimitive(r40);
|
---|
241 | source.addPrimitive(r1);
|
---|
242 | source.setSelected(r1);
|
---|
243 |
|
---|
244 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
245 | DataSet hull = builder.build();
|
---|
246 | assertNotNull(hull);
|
---|
247 | assertEquals(1, hull.getWays().size());
|
---|
248 | assertEquals(1, hull.getNodes().size());
|
---|
249 | assertEquals(2, hull.getRelations().size());
|
---|
250 |
|
---|
251 | OsmPrimitive p = hull.getPrimitiveById(1, OsmPrimitiveType.RELATION);
|
---|
252 | assertNotNull(p);
|
---|
253 | assertEquals(p.getClass(), Relation.class);
|
---|
254 |
|
---|
255 | Way w = (Way) hull.getPrimitiveById(30, OsmPrimitiveType.WAY);
|
---|
256 | assertNotNull(w);
|
---|
257 | assertTrue(w.isIncomplete());
|
---|
258 |
|
---|
259 |
|
---|
260 | Node n = (Node) hull.getPrimitiveById(21, OsmPrimitiveType.NODE);
|
---|
261 | assertNull(n);
|
---|
262 |
|
---|
263 | n = (Node) hull.getPrimitiveById(22, OsmPrimitiveType.NODE);
|
---|
264 | assertNull(n);
|
---|
265 |
|
---|
266 | Relation r = (Relation) hull.getPrimitiveById(40, OsmPrimitiveType.RELATION);
|
---|
267 | assertNotNull(r);
|
---|
268 | assertTrue(r.isIncomplete());
|
---|
269 |
|
---|
270 | r = (Relation) hull.getPrimitiveById(1, OsmPrimitiveType.RELATION);
|
---|
271 | assertNotNull(r);
|
---|
272 | assertEquals(3, r.getMembersCount());
|
---|
273 | RelationMember m = new RelationMember("node-20", hull.getPrimitiveById(20, OsmPrimitiveType.NODE));
|
---|
274 | assertTrue(r.getMembers().contains(m));
|
---|
275 | m = new RelationMember("way-30", hull.getPrimitiveById(30, OsmPrimitiveType.WAY));
|
---|
276 | assertTrue(r.getMembers().contains(m));
|
---|
277 | m = new RelationMember("relation-40", hull.getPrimitiveById(40, OsmPrimitiveType.RELATION));
|
---|
278 | assertTrue(r.getMembers().contains(m));
|
---|
279 | }
|
---|
280 |
|
---|
281 | @Test
|
---|
282 | public void testOneRelationNewMembersNotSelected() {
|
---|
283 | DataSet source = new DataSet();
|
---|
284 | Relation r1 = new Relation();
|
---|
285 | r1.put("name", "r1");
|
---|
286 | Node n20 = new Node(new LatLon(20.0, 20.0));
|
---|
287 | n20.put("name", "n20");
|
---|
288 | r1.addMember(new RelationMember("node-20", n20));
|
---|
289 |
|
---|
290 | Way w30 = new Way();
|
---|
291 | w30.put("name", "w30");
|
---|
292 | Node n21;
|
---|
293 | w30.addNode(n21 = new Node(new LatLon(21.0, 21.0)));
|
---|
294 | n21.put("name", "n21");
|
---|
295 | Node n22;
|
---|
296 | w30.addNode(n22 = new Node(new LatLon(22.0, 22.0)));
|
---|
297 | n22.put("name", "n22");
|
---|
298 | r1.addMember(new RelationMember("way-30", w30));
|
---|
299 | Relation r40 = new Relation();
|
---|
300 | r40.put("name", "r40");
|
---|
301 | r1.addMember(new RelationMember("relation-40", r40));
|
---|
302 |
|
---|
303 | source.addPrimitive(n20);
|
---|
304 | source.addPrimitive(n21);
|
---|
305 | source.addPrimitive(n22);
|
---|
306 | source.addPrimitive(w30);
|
---|
307 | source.addPrimitive(r40);
|
---|
308 | source.addPrimitive(r1);
|
---|
309 | source.setSelected(r1);
|
---|
310 |
|
---|
311 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
312 | DataSet hull = builder.build();
|
---|
313 | assertNotNull(hull);
|
---|
314 | assertEquals(1, hull.getWays().size());
|
---|
315 | assertEquals(3, hull.getNodes().size());
|
---|
316 | assertEquals(2, hull.getRelations().size());
|
---|
317 |
|
---|
318 | OsmPrimitive p = lookupByName(hull.getRelations(), "r1");
|
---|
319 | assertNotNull(p);
|
---|
320 | assertEquals(p.getClass(), Relation.class);
|
---|
321 |
|
---|
322 | Way w = (Way) lookupByName(hull.getWays(), "w30");
|
---|
323 | assertNotNull(w);
|
---|
324 | assertEquals(2, w.getNodesCount());
|
---|
325 |
|
---|
326 | Node n = (Node) lookupByName(hull.getNodes(), "n21");
|
---|
327 | assertNotNull(n);
|
---|
328 | assertTrue(w.containsNode(n));
|
---|
329 |
|
---|
330 | n = (Node) lookupByName(hull.getNodes(), "n22");
|
---|
331 | assertNotNull(n);
|
---|
332 | assertTrue(w.containsNode(n));
|
---|
333 |
|
---|
334 | Relation r = (Relation) lookupByName(hull.getRelations(), "r40");
|
---|
335 | assertNotNull(r);
|
---|
336 |
|
---|
337 | r = (Relation) lookupByName(hull.getRelations(), "r1");
|
---|
338 | assertNotNull(r);
|
---|
339 | assertEquals(3, r.getMembersCount());
|
---|
340 | RelationMember m = new RelationMember("node-20", lookupByName(hull.getNodes(), "n20"));
|
---|
341 | assertTrue(r.getMembers().contains(m));
|
---|
342 | m = new RelationMember("way-30", lookupByName(hull.getWays(), "w30"));
|
---|
343 | assertTrue(r.getMembers().contains(m));
|
---|
344 | m = new RelationMember("relation-40", lookupByName(hull.getRelations(), "r40"));
|
---|
345 | assertTrue(r.getMembers().contains(m));
|
---|
346 | }
|
---|
347 |
|
---|
348 | @Test
|
---|
349 | public void testOneRelationExistingRecursive() {
|
---|
350 | DataSet source = new DataSet();
|
---|
351 | Relation r1 = new Relation(1, 1);
|
---|
352 | r1.addMember(new RelationMember("relation-1", r1));
|
---|
353 | source.addPrimitive(r1);
|
---|
354 | source.setSelected(r1);
|
---|
355 |
|
---|
356 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
357 | DataSet hull = builder.build();
|
---|
358 | assertNotNull(hull);
|
---|
359 | assertEquals(1, hull.getRelations().size());
|
---|
360 |
|
---|
361 | Relation r = (Relation) hull.getPrimitiveById(1, OsmPrimitiveType.RELATION);
|
---|
362 | assertNotNull(r);
|
---|
363 | assertEquals(1, r.getMembersCount());
|
---|
364 | assertTrue(r.getMembers().contains(new RelationMember("relation-1", r)));
|
---|
365 | }
|
---|
366 |
|
---|
367 | @Test
|
---|
368 | public void testOneRelationNewRecursive() {
|
---|
369 | DataSet source = new DataSet();
|
---|
370 | Relation r1 = new Relation();
|
---|
371 | r1.put("name", "r1");
|
---|
372 | r1.addMember(new RelationMember("relation-1", r1));
|
---|
373 | source.addPrimitive(r1);
|
---|
374 | source.setSelected(r1);
|
---|
375 |
|
---|
376 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
377 | DataSet hull = builder.build();
|
---|
378 | assertNotNull(hull);
|
---|
379 | assertEquals(1, hull.getRelations().size());
|
---|
380 |
|
---|
381 | Relation r = (Relation) lookupByName(hull.getRelations(), "r1");
|
---|
382 | assertNotNull(r);
|
---|
383 | assertEquals(1, r.getMembersCount());
|
---|
384 | assertTrue(r.getMembers().contains(new RelationMember("relation-1", r)));
|
---|
385 | }
|
---|
386 |
|
---|
387 | @Test
|
---|
388 | public void testTwoRelationExistingCircular() {
|
---|
389 | DataSet source = new DataSet();
|
---|
390 | Relation r1 = new Relation(1, 1);
|
---|
391 | source.addPrimitive(r1);
|
---|
392 | Relation r2 = new Relation(2, 3);
|
---|
393 | source.addPrimitive(r2);
|
---|
394 | r1.addMember(new RelationMember("relation-2", r2));
|
---|
395 | r2.addMember(new RelationMember("relation-1", r1));
|
---|
396 | source.setSelected(r1, r2);
|
---|
397 |
|
---|
398 | MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(source);
|
---|
399 | DataSet hull = builder.build();
|
---|
400 | assertNotNull(hull);
|
---|
401 | assertEquals(2, hull.getRelations().size());
|
---|
402 |
|
---|
403 | r1 = (Relation) hull.getPrimitiveById(1, OsmPrimitiveType.RELATION);
|
---|
404 | assertNotNull(r1);
|
---|
405 | r2 = (Relation) hull.getPrimitiveById(2, OsmPrimitiveType.RELATION);
|
---|
406 | assertNotNull(r2);
|
---|
407 | assertEquals(1, r1.getMembersCount());
|
---|
408 | assertTrue(r1.getMembers().contains(new RelationMember("relation-2", r2)));
|
---|
409 | assertEquals(1, r2.getMembersCount());
|
---|
410 | assertTrue(r2.getMembers().contains(new RelationMember("relation-1", r1)));
|
---|
411 | }
|
---|
412 | }
|
---|