| 1 | // License: GPL. For details, see LICENSE file.
|
|---|
| 2 | package org.openstreetmap.josm.corrector;
|
|---|
| 3 |
|
|---|
| 4 | import java.util.Collections;
|
|---|
| 5 | import java.util.List;
|
|---|
| 6 | import java.util.Map;
|
|---|
| 7 | import java.util.stream.Stream;
|
|---|
| 8 |
|
|---|
| 9 | import org.junit.Assert;
|
|---|
| 10 | import org.junit.Rule;
|
|---|
| 11 | import org.junit.Test;
|
|---|
| 12 | import org.openstreetmap.josm.data.correction.TagCorrection;
|
|---|
| 13 | import org.openstreetmap.josm.data.osm.Node;
|
|---|
| 14 | import org.openstreetmap.josm.data.osm.OsmPrimitive;
|
|---|
| 15 | import org.openstreetmap.josm.data.osm.OsmUtils;
|
|---|
| 16 | import org.openstreetmap.josm.data.osm.Tag;
|
|---|
| 17 | import org.openstreetmap.josm.data.osm.Way;
|
|---|
| 18 | import org.openstreetmap.josm.testutils.JOSMTestRules;
|
|---|
| 19 |
|
|---|
| 20 | import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
|
|---|
| 21 | import net.trajano.commons.testing.UtilityClassTestUtil;
|
|---|
| 22 |
|
|---|
| 23 | /**
|
|---|
| 24 | * Unit tests of {@link ReverseWayTagCorrector} class.
|
|---|
| 25 | */
|
|---|
| 26 | public class ReverseWayTagCorrectorTest {
|
|---|
| 27 |
|
|---|
| 28 | /**
|
|---|
| 29 | * Setup test.
|
|---|
| 30 | */
|
|---|
| 31 | @Rule
|
|---|
| 32 | @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
|
|---|
| 33 | public JOSMTestRules test = new JOSMTestRules();
|
|---|
| 34 |
|
|---|
| 35 | /**
|
|---|
| 36 | * Tests that {@code ReverseWayTagCorrector.TagSwitcher} satisfies utility class criterias.
|
|---|
| 37 | * @throws ReflectiveOperationException if an error occurs
|
|---|
| 38 | */
|
|---|
| 39 | @Test
|
|---|
| 40 | public void testUtilityClass() throws ReflectiveOperationException {
|
|---|
| 41 | UtilityClassTestUtil.assertUtilityClassWellDefined(ReverseWayTagCorrector.TagSwitcher.class);
|
|---|
| 42 | }
|
|---|
| 43 |
|
|---|
| 44 | /**
|
|---|
| 45 | * Test of {@link ReverseWayTagCorrector.TagSwitcher#apply} method.
|
|---|
| 46 | */
|
|---|
| 47 | @Test
|
|---|
| 48 | public void testTagSwitch() {
|
|---|
| 49 | // oneway
|
|---|
| 50 | assertSwitch(new Tag("oneway", "yes"), new Tag("oneway", "-1"));
|
|---|
| 51 | assertSwitch(new Tag("oneway", "true"), new Tag("oneway", "-1"));
|
|---|
| 52 | assertSwitch(new Tag("oneway", "-1"), new Tag("oneway", "yes"));
|
|---|
| 53 | assertSwitch(new Tag("oneway", "no"), new Tag("oneway", "no"));
|
|---|
| 54 | assertSwitch(new Tag("oneway", "something"), new Tag("oneway", "something"));
|
|---|
| 55 | // incline/direction
|
|---|
| 56 | for (String k : new String[]{"incline", "direction"}) {
|
|---|
| 57 | assertSwitch(new Tag(k, "up"), new Tag(k, "down"));
|
|---|
| 58 | assertSwitch(new Tag(k, "down"), new Tag(k, "up"));
|
|---|
| 59 | assertSwitch(new Tag(k, "something"), new Tag(k, "something"));
|
|---|
| 60 | }
|
|---|
| 61 | // direction=forward/backward/...
|
|---|
| 62 | assertSwitch(new Tag("direction", "forward"), new Tag("direction", "backward"));
|
|---|
| 63 | assertSwitch(new Tag("direction", "backward"), new Tag("direction", "forward"));
|
|---|
| 64 | assertSwitch(new Tag("direction", "north"), new Tag("direction", "south"));
|
|---|
| 65 | // :left/:right with oneway (see #10977)
|
|---|
| 66 | assertSwitch(new Tag("cycleway:left:oneway", "-1"), new Tag("cycleway:right:oneway", "yes"));
|
|---|
| 67 | // :forward/:backward (see #8518)
|
|---|
| 68 | assertSwitch(new Tag("turn:forward", "right"), new Tag("turn:backward", "right"));
|
|---|
| 69 | assertSwitch(new Tag("change:forward", "not_right"), new Tag("change:backward", "not_right"));
|
|---|
| 70 | assertSwitch(new Tag("placement:forward", "right_of:1"), new Tag("placement:backward", "right_of:1"));
|
|---|
| 71 | assertSwitch(new Tag("turn:lanes:forward", "left|right"), new Tag("turn:lanes:backward", "left|right"));
|
|---|
| 72 | assertSwitch(new Tag("change:lanes:forward", "not_right|only_left"), new Tag("change:lanes:backward", "not_right|only_left"));
|
|---|
| 73 | // keys
|
|---|
| 74 | assertSwitch(new Tag("forward", "something"), new Tag("backward", "something"));
|
|---|
| 75 | assertSwitch(new Tag("backward", "something"), new Tag("forward", "something"));
|
|---|
| 76 | assertSwitch(new Tag("up", "something"), new Tag("down", "something"));
|
|---|
| 77 | assertSwitch(new Tag("down", "something"), new Tag("up", "something"));
|
|---|
| 78 | assertSwitch(new Tag("east", "something"), new Tag("west", "something"));
|
|---|
| 79 | assertSwitch(new Tag("west", "something"), new Tag("east", "something"));
|
|---|
| 80 | assertSwitch(new Tag("south", "something"), new Tag("north", "something"));
|
|---|
| 81 | assertSwitch(new Tag("north", "something"), new Tag("south", "something"));
|
|---|
| 82 | // values
|
|---|
| 83 | assertSwitch(new Tag("something", "forward"), new Tag("something", "backward"));
|
|---|
| 84 | assertSwitch(new Tag("something", "backward"), new Tag("something", "forward"));
|
|---|
| 85 | assertSwitch(new Tag("something", "up"), new Tag("something", "down"));
|
|---|
| 86 | assertSwitch(new Tag("something", "down"), new Tag("something", "up"));
|
|---|
| 87 | assertSwitch(new Tag("something", "east"), new Tag("something", "west"));
|
|---|
| 88 | assertSwitch(new Tag("something", "west"), new Tag("something", "east"));
|
|---|
| 89 | assertSwitch(new Tag("something", "south"), new Tag("something", "north"));
|
|---|
| 90 | assertSwitch(new Tag("something", "north"), new Tag("something", "south"));
|
|---|
| 91 | // value[:_]suffix
|
|---|
| 92 | assertSwitch(new Tag("something", "forward:suffix"), new Tag("something", "backward:suffix"));
|
|---|
| 93 | assertSwitch(new Tag("something", "backward_suffix"), new Tag("something", "forward_suffix"));
|
|---|
| 94 | assertSwitch(new Tag("something", "up:suffix"), new Tag("something", "down:suffix"));
|
|---|
| 95 | assertSwitch(new Tag("something", "down_suffix"), new Tag("something", "up_suffix"));
|
|---|
| 96 | assertSwitch(new Tag("something", "east:suffix"), new Tag("something", "west:suffix"));
|
|---|
| 97 | assertSwitch(new Tag("something", "west_suffix"), new Tag("something", "east_suffix"));
|
|---|
| 98 | assertSwitch(new Tag("something", "south:suffix"), new Tag("something", "north:suffix"));
|
|---|
| 99 | assertSwitch(new Tag("something", "north_suffix"), new Tag("something", "south_suffix"));
|
|---|
| 100 | // prefix[:_]value
|
|---|
| 101 | assertSwitch(new Tag("something", "prefix:forward"), new Tag("something", "prefix:backward"));
|
|---|
| 102 | assertSwitch(new Tag("something", "prefix_backward"), new Tag("something", "prefix_forward"));
|
|---|
| 103 | assertSwitch(new Tag("something", "prefix:up"), new Tag("something", "prefix:down"));
|
|---|
| 104 | assertSwitch(new Tag("something", "prefix_down"), new Tag("something", "prefix_up"));
|
|---|
| 105 | assertSwitch(new Tag("something", "prefix:east"), new Tag("something", "prefix:west"));
|
|---|
| 106 | assertSwitch(new Tag("something", "prefix_west"), new Tag("something", "prefix_east"));
|
|---|
| 107 | assertSwitch(new Tag("something", "prefix:south"), new Tag("something", "prefix:north"));
|
|---|
| 108 | assertSwitch(new Tag("something", "prefix_north"), new Tag("something", "prefix_south"));
|
|---|
| 109 | // prefix[:_]value[:_]suffix
|
|---|
| 110 | assertSwitch(new Tag("something", "prefix:forward:suffix"), new Tag("something", "prefix:backward:suffix"));
|
|---|
| 111 | assertSwitch(new Tag("something", "prefix_backward:suffix"), new Tag("something", "prefix_forward:suffix"));
|
|---|
| 112 | assertSwitch(new Tag("something", "prefix:up_suffix"), new Tag("something", "prefix:down_suffix"));
|
|---|
| 113 | assertSwitch(new Tag("something", "prefix_down_suffix"), new Tag("something", "prefix_up_suffix"));
|
|---|
| 114 | assertSwitch(new Tag("something", "prefix:east:suffix"), new Tag("something", "prefix:west:suffix"));
|
|---|
| 115 | assertSwitch(new Tag("something", "prefix_west:suffix"), new Tag("something", "prefix_east:suffix"));
|
|---|
| 116 | assertSwitch(new Tag("something", "prefix:south_suffix"), new Tag("something", "prefix:north_suffix"));
|
|---|
| 117 | assertSwitch(new Tag("something", "prefix_north_suffix"), new Tag("something", "prefix_south_suffix"));
|
|---|
| 118 | // #8499
|
|---|
| 119 | assertSwitch(new Tag("type", "drawdown"), new Tag("type", "drawdown"));
|
|---|
| 120 | }
|
|---|
| 121 |
|
|---|
| 122 | private void assertSwitch(Tag oldTag, Tag newTag) {
|
|---|
| 123 | Assert.assertEquals(ReverseWayTagCorrector.TagSwitcher.apply(oldTag), newTag);
|
|---|
| 124 | }
|
|---|
| 125 |
|
|---|
| 126 | private Map<OsmPrimitive, List<TagCorrection>> getTagCorrectionsForWay(String middleNodeTags) {
|
|---|
| 127 | final OsmPrimitive n1 = OsmUtils.createPrimitive("node");
|
|---|
| 128 | final OsmPrimitive n2 = OsmUtils.createPrimitive("node " + middleNodeTags);
|
|---|
| 129 | final OsmPrimitive n3 = OsmUtils.createPrimitive("node");
|
|---|
| 130 | final Way w = new Way();
|
|---|
| 131 | Stream.of(n1, n2, n3).map(Node.class::cast).forEach(w::addNode);
|
|---|
| 132 | return ReverseWayTagCorrector.getTagCorrectionsMap(w);
|
|---|
| 133 | }
|
|---|
| 134 |
|
|---|
| 135 | /**
|
|---|
| 136 | * Test tag correction on way nodes
|
|---|
| 137 | */
|
|---|
| 138 | @Test
|
|---|
| 139 | public void testSwitchingWayNodes() {
|
|---|
| 140 | final Map<OsmPrimitive, List<TagCorrection>> tagCorrections = getTagCorrectionsForWay("direction=forward");
|
|---|
| 141 | Assert.assertEquals(1, tagCorrections.size());
|
|---|
| 142 | Assert.assertEquals(Collections.singletonList(new TagCorrection("direction", "forward", "direction", "backward")),
|
|---|
| 143 | tagCorrections.values().iterator().next());
|
|---|
| 144 | }
|
|---|
| 145 |
|
|---|
| 146 | /**
|
|---|
| 147 | * Test tag correction on way nodes are not applied for absolute values such as compass cardinal directions
|
|---|
| 148 | */
|
|---|
| 149 | @Test
|
|---|
| 150 | public void testNotSwitchingWayNodes() {
|
|---|
| 151 | Assert.assertEquals(0, getTagCorrectionsForWay("direction=SSW").size());
|
|---|
| 152 | Assert.assertEquals(0, getTagCorrectionsForWay("direction=145").size());
|
|---|
| 153 | }
|
|---|
| 154 | }
|
|---|
